Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): unhandled native exceptions should show an error dialog #12721

Merged
merged 4 commits into from
Jun 16, 2021
Merged

fix(ios): unhandled native exceptions should show an error dialog #12721

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
efc0994
fix(ios): unhandled native exceptions should show error dialog
jquick-axway Apr 14, 2021
90dbb9f
chore(ios): simplified code change for TIMOB-28420
jquick-axway Apr 26, 2021
efd8bbc
Merge branch 'master' into TIMOB-28420
sgtcoolguy May 3, 2021
abc86d6
Merge branch 'master' into TIMOB-28420
lokeshchdhry Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 12 additions & 1 deletion iphone/TitaniumKit/TitaniumKit/Sources/API/TiExceptionHandler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,19 @@ - (id)initWithDictionary:(NSDictionary *)dictionary
if (_backtrace == nil) {
_backtrace = [[[dictionary objectForKey:@"stack"] description] copy];
}
_nativeStack = [[dictionary objectForKey:@"nativeStack"] copy];
_dictionaryValue = [dictionary copy];

id nativeStackObject = [dictionary objectForKey:@"nativeStack"];
if (nativeStackObject) {
if ([nativeStackObject isKindOfClass:[NSArray class]]) {
nativeStackObject = [nativeStackObject copy];
jquick-axway marked this conversation as resolved.
Show resolved Hide resolved
} else if ([nativeStackObject isKindOfClass:[NSString class]]) {
nativeStackObject = [[nativeStackObject componentsSeparatedByString:@"\n"] retain];
jquick-axway marked this conversation as resolved.
Show resolved Hide resolved
} else {
nativeStackObject = nil;
}
}
_nativeStack = nativeStackObject;
jquick-axway marked this conversation as resolved.
Show resolved Hide resolved
}
return self;
}
Expand Down