Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(android): remove unneeded warnings #12783

Merged
merged 4 commits into from
May 20, 2021
Merged

chore(android): remove unneeded warnings #12783

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d695b1
chore(android): remove synchronous stream deprecation warnings
jquick-axway May 7, 2021
241c6b1
chore(android): remove "Could not open stream to get bitmap" warnings
jquick-axway May 7, 2021
812094d
Merge branch 'master' into TIMOB-28441
garymathews May 7, 2021
ce19398
chore(android): delay "uncaughtException" event deprecations to 11.0.0
jquick-axway May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 1 addition & 14 deletions android/titanium/src/java/org/appcelerator/titanium/util/TiStreamHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
* Appcelerator Titanium Mobile
* Copyright (c) 2009-2018 by Appcelerator, Inc. All Rights Reserved.
* Copyright (c) 2009-2021 by Axway, Inc. All Rights Reserved.
* Licensed under the terms of the Apache Public License
* Please see the LICENSE included with this distribution for details.
*/
Expand All @@ -10,14 +10,11 @@
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;

import org.appcelerator.kroll.KrollDict;
import org.appcelerator.kroll.KrollFunction;
import org.appcelerator.kroll.KrollObject;
import org.appcelerator.kroll.common.Log;
import org.appcelerator.titanium.TiApplication;
import org.appcelerator.titanium.io.TiStream;

import ti.modules.titanium.BufferProxy;

public class TiStreamHelper
Expand Down Expand Up @@ -81,11 +78,6 @@ public static int readTiStream(final String TAG, final KrollObject krollObject,
return 0;
}

String warningMessage
= "Synchronous invocation of read will cause performance issues under the main thread."
+ " This will no longer be supported in SDK 10.0.0."
+ " Please invoke with a final callback function to receive the result.";
Log.w(TAG, warningMessage);
final BufferProxy finalBufferProxy = bufferProxy;
final int finalOffset = offset;
final int finalLength = length;
Expand Down Expand Up @@ -182,11 +174,6 @@ public static int writeTiStream(final String TAG, final KrollObject krollObject,
return 0;
}

String warningMessage
= "Synchronous invocation of write will cause performance issues under the main thread."
+ " This will no longer be supported in SDK 10.0.0."
+ " Please invoke with a final callback function to receive the result.";
Log.w(TAG, warningMessage);
final BufferProxy finalBufferProxy = bufferProxy;
final int finalOffset = offset;
final int finalLength = length;
Expand Down
3 changes: 0 additions & 3 deletions android/titanium/src/java/org/appcelerator/titanium/view/TiDrawableReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,6 @@ public Bitmap getBitmap(boolean needRetry, boolean densityScaled)
}
} else {
if (is == null) {
Log.w(TAG, "Could not open stream to get bitmap");
return null;
}
try {
Expand All @@ -418,7 +417,6 @@ public Bitmap getBitmap(boolean needRetry, boolean densityScaled)
}
} finally {
if (is == null) {
Log.w(TAG, "Could not open stream to get bitmap");
return null;
}
try {
Expand Down Expand Up @@ -673,7 +671,6 @@ public Bitmap getBitmap(View parent, TiDimension destWidthDimension, TiDimension

InputStream is = getInputStream();
if (is == null) {
Log.w(TAG, "Could not open stream to get bitmap");
return null;
}

Expand Down