Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(android): remove unneeded warnings #12783

Merged
merged 4 commits into from
May 20, 2021
Merged

chore(android): remove unneeded warnings #12783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d695b1
chore(android): remove synchronous stream deprecation warnings
jquick-axway May 7, 2021
241c6b1
chore(android): remove "Could not open stream to get bitmap" warnings
jquick-axway May 7, 2021
812094d
Merge branch 'master' into TIMOB-28441
garymathews May 7, 2021
ce19398
chore(android): delay "uncaughtException" event deprecations to 11.0.0
jquick-axway May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/titanium/src/java/org/appcelerator/titanium/TiExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public class TiExceptionHandler implements Handler.Callback, KrollExceptionHandl
public static final String ERROR_STACK = "stack";
public static final String ERROR_NATIVESTACK = "nativeStack";

// DEPRECATED in 9.0.0, REMOVE 10.0.0
// DEPRECATED in 9.0.0, REMOVE 11.0.0
public static final String ERROR_LINEOFFSET = "lineOffset";
public static final String ERROR_JS_STACK = "javascriptStack";
public static final String ERROR_JAVA_STACK = "javaStack";
Expand All @@ -78,7 +78,7 @@ public static KrollDict getErrorDict(ExceptionMessage error)
dict.put(ERROR_STACK, error.jsStack);
dict.put(ERROR_NATIVESTACK, error.javaStack);

// DEPRECATED in 9.0.0, REMOVE 10.0.0
// DEPRECATED in 9.0.0, REMOVE 11.0.0
dict.put(ERROR_LINEOFFSET, error.lineOffset);
dict.put(ERROR_JS_STACK, error.jsStack);
dict.put(ERROR_JAVA_STACK, error.javaStack);
Expand Down
8 changes: 4 additions & 4 deletions apidoc/Titanium/App/App.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,22 +309,22 @@ events:
type: String
platforms: [android]
- name: lineOffset
summary: The offset on the line where the error occurred.
summary: The offset on the line where the error occurred. (Deprecated since 9.0.0. Use `column` instead.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use the deprecated attribute

deprecated: 
    since: "9.0.0"
    notes: Use the `column` property instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yml "deprecated" attribute is ignored for "event properties" in our old and new doc websites. Only the "summary" is used, which is why I'm duplicating this info there.
https://docs.appcelerator.com/platform/latest/#!/api/Titanium.App-event-uncaughtException
https://titaniumsdk.com/api/titanium/app.html#uncaughtexception

type: Number
deprecated:
since: "9.0.0"
notes: Use `column` property for cross-platform parity.
platforms: [android]
- name: jsStack
summary: The javascript stack trace of the exception.
- name: javascriptStack
summary: The javascript stack trace of the exception. (Deprecated since 9.0.0. Use `stack` instead.)
type: String
since: "8.0.0"
deprecated:
since: "9.0.0"
notes: Use `stack` property for cross-platform parity.
platforms: [android]
- name: javaStack
summary: The java stack trace of the exception.
summary: The java stack trace of the exception. (Deprecated since 9.0.0. Use `nativeStack` instead.)
type: String
since: "8.0.0"
deprecated:
Expand Down