Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): fix drag and drop issues #13387

Merged
merged 7 commits into from
Apr 11, 2022

Conversation

hansemannn
Copy link
Collaborator

Fixes #13386

@hansemannn hansemannn requested a review from m1ga April 11, 2022 16:54
@m1ga m1ga self-requested a review April 11, 2022 18:13
Copy link
Contributor

@m1ga m1ga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with

const window = Ti.UI.createWindow();
const btn = Ti.UI.createButton({title:'edit', bottom: 0});
const listView = Ti.UI.createListView({
	editing: true,
	sections: [
		Ti.UI.createListSection({
			headerTitle: 'Section 1',
			items: [
				{ properties: { title: 'Item 1', canMove: true } },
				{ properties: { title: 'Item 2', canMove: true } },
				{ properties: { title: 'Item 3', canMove: true } }
			]
		}),
		Ti.UI.createListSection({
			headerTitle: 'Section 2',
			items: [
				{ properties: { title: 'Item 1', canMove: true } },
				{ properties: { title: 'Item 2', canMove: true } },
				{ properties: { title: 'Item 3', canMove: true } }
			]
		})
	]
});

btn.addEventListener('click', function(){
	listView.editing = !listView.editing;
})

window.add(btn);
window.add(listView);
window.open();

in edit and non edit mode. Working fine

  • old "hold touch and move" still works
  • new single drag on the icon works fine

feels very good in edit mode now 👍

Tested on:

  • Android 12, device (Pixel 4), Light/Dark mode
  • Android 13, Emulator

@hansemannn hansemannn merged commit cffee52 into tidev:master Apr 11, 2022
@hansemannn hansemannn deleted the fix/android-drag-and-drop-issues branch April 11, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android: New moveable list items only move when dragged via long-press
2 participants