[TIMOB-7363][TIMOB-7425][TIMOB-7455] [1_7_X] barImage handling #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added in -[TiUtils isIOS5OrGreater] Conflicts: iphone/Classes/TiUIWindowProxy.m
|
Should this PR need commits from PR #1292 ? |
|
Code Reviewed ... as vishal noted barimage is not being allocated... i think there was merge error while cherry picking. |
|
This comment needs to be more specific. I'm not seeing where in the code this is missing based on diffs. |
|
Closing this PR to submit a new one based on diff patching. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of PR #1252 for 1_7_X.
Should not be reviewed by myself or Vishal. But see comments below regarding the other cherry-picks to resolve the regressions introduced by the original fix. All three tickets should be tested as well as a KS pass on barImage to ensure that there is no behavior difference from vanilla 1.7.x.