fix(ios/build): support passing target and device id to the module build #13808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arguments are copied as is over to the app build process at the end of the module build, there is also a change to return early in `initTiappSettings` in the app build. This is because all build options are ran so `--device-id` to a module build triggers the app build checks, which then subsequently fail. There is definitely a better fix for this, but this for now at least allows it to work and unblocks the related VS Code feature
ewanharris
force-pushed
the
fix/ios-allow-device-id-during-module
branch
from
779b48a
to
ffce062
Compare
cb1kenobi
approved these changes
Apr 19, 2023
Co-authored-by: Chris Barber <chris.barber@vercel.com>
hansemannn
pushed a commit
that referenced
this pull request
Apr 24, 2023
…ild (#13808) Co-authored-by: Chris Barber <chris@cb1inc.com>
narbs
pushed a commit
to narbs/titanium_mobile
that referenced
this pull request
Jun 7, 2023
…ild (tidev#13808) Co-authored-by: Chris Barber <chris@cb1inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments are copied as is over to the app build process at the end of the module build, there is also a change to return early in
initTiappSettingsin the app build. This is because all build options are ran so--device-idto a module build triggers the app build checks, which then subsequently fail. There is definitely a better fix for this, but this for now at least allows it to work and unblocks the related VS Code featureThis is related to #13432