Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: npm packages #13886

Merged
merged 29 commits into from
May 14, 2024
Merged

chore: npm packages #13886

merged 29 commits into from
May 14, 2024

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Jul 27, 2023

just some node package updates.

Updated my info list too #13781 as many are ESM packages now in newer versions.

Tested with kitchensink, hyperloop-example, my app and another client app (all Android only)

Had to run npm run format:objc to fix the lint errors

@cb1kenobi
Copy link
Contributor

Wow. This. PR. Is. Huge. Nice.

@m1ga
Copy link
Contributor Author

m1ga commented Aug 1, 2023

my changes are only in the package.json :-) The rest is done with format:objc. Looks like the rules changed or it is just a bit stricter now and it wasn't formatted before

@m1ga m1ga mentioned this pull request Aug 3, 2023
@m1ga
Copy link
Contributor Author

m1ga commented Dec 31, 2023

finally fixed the merge conflicts and linting errors.

For comparison:

before: 37 vulnerabilities (1 low, 23 moderate, 10 high, 3 critical)
after: 26 vulnerabilities (1 low, 16 moderate, 6 high, 3 critical)

not all but at least some 😄

@m1ga
Copy link
Contributor Author

m1ga commented May 13, 2024

updated stats:
after the PR it is now 29 vulnerabilities (1 low, 18 moderate, 6 high, 4 critical)

Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through everything and made a bunch suggestions that you can click to accept.

I still need to audit all of the updated npom dependencies. I'm particularily interested in what changed in all major releases: arborist, archiver, fs-extra, chai, commander, conventional-changelog-cli, danger, eslint-config-axway, glob, husky, ssri, and strip-ansi. I don't know how each of these deps are used, so better to be safe than sorry.

iphone/Classes/TiUINavBarButton.m Outdated Show resolved Hide resolved
iphone/Classes/TiUIScrollableView.m Outdated Show resolved Hide resolved
iphone/Classes/TiUITableViewProxy.m Outdated Show resolved Hide resolved
iphone/Classes/TiUIiOSProxy.h Outdated Show resolved Hide resolved
iphone/Classes/TiUIiOSStepper.m Outdated Show resolved Hide resolved
iphone/TitaniumKit/TitaniumKit/Sources/API/TiProxy.m Outdated Show resolved Hide resolved
iphone/TitaniumKit/TitaniumKit/Sources/API/TiStylesheet.m Outdated Show resolved Hide resolved
iphone/TitaniumKit/TitaniumKit/Sources/API/TiUIView.m Outdated Show resolved Hide resolved
iphone/TitaniumKit/TitaniumKit/Sources/API/TiViewProxy.m Outdated Show resolved Hide resolved
@m1ga
Copy link
Contributor Author

m1ga commented May 13, 2024

I went through everything and made a bunch suggestions that you can click to accept.

I still need to audit all of the updated npom dependencies. I'm particularily interested in what changed in all major releases: arborist, archiver, fs-extra, chai, commander, conventional-changelog-cli, danger, eslint-config-axway, glob, husky, ssri, and strip-ansi. I don't know how each of these deps are used, so better to be safe than sorry.

nice 👍 Just a quick note: I think all the changes will automatically come back once someone runs npm run format:objc but let's see if the linter likes your changes. I'll commit some to let it run a build...if its fine I'll submit the other ones too

m1ga and others added 4 commits May 13, 2024 18:48
Co-authored-by: Chris Barber <chris@cb1inc.com>
Co-authored-by: Chris Barber <chris@cb1inc.com>
Co-authored-by: Chris Barber <chris@cb1inc.com>
@cb1kenobi
Copy link
Contributor

@m1ga it seems like the linter gets confused in multi-line comments. If the linter still doesn't like the suggested indentations, then so be it. I'm curious what it'll say.

m1ga and others added 3 commits May 13, 2024 18:58
Co-authored-by: Chris Barber <chris@cb1inc.com>
Co-authored-by: Chris Barber <chris@cb1inc.com>
Co-authored-by: Chris Barber <chris@cb1inc.com>
@m1ga
Copy link
Contributor Author

m1ga commented May 13, 2024

That worked and it doesn't want to change them again when running npm run format:objc 👍

Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I audited the npm deps as best as I could. I did some testing and things look good. I'll approve and merge this PR, then we can get people to help test. APPROVED!

@cb1kenobi cb1kenobi merged commit 48afddf into master May 14, 2024
5 checks passed
@m1ga m1ga deleted the 230727_npm branch May 27, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants