fix(ios): building for MacOS (Catalyst) now works with that fix #13903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building was not working because of not longer supported removeFromSuperView in MacOSCatalyst Updated Titanium.xcodeproj to correct destination settings for using same bundleId for iOS and MacOS
m1ga
reviewed
Sep 1, 2023
mbender74
commented
Sep 2, 2023
|
Once the layout-changes from my other PR are cherry-picked and the iOS build works again (this is just a linting issue which should be solved with the cherry-pick), we can merge this and backport it for the 12.2.0.GA :-) No worries, I can do the backport once merged! |
|
@hansemannn I take over #13899 and now all checks passed :-) |
hansemannn
approved these changes
Sep 4, 2023
hansemannn
pushed a commit
that referenced
this pull request
Sep 4, 2023
* fix(ios): building for MacOS (Catalyst) now works with that fix Building was not working because of not longer supported removeFromSuperView in MacOSCatalyst Updated Titanium.xcodeproj to correct destination settings for using same bundleId for iOS and MacOS * fix(ios): building for MacOS (Catalyst) finding all provisioning profiles * fix(ios): tab/spaces correction and m1ga hint correted about the WWDR cert * fix(macos): fix layout issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building was not working because of not longer supported removeFromSuperView in MacOSCatalyst Updated Titanium.xcodeproj to correct destination settings for using same bundleId for iOS and MacOS