[TIDOC-414] [TIDOC-120] [TIDOC-245] [TIDOC-188] APIDoc: UI.ScrollView rewrite #1515
Conversation
| - name: scale | ||
| summary: New scaling factor as a float. | ||
| type: Number | ||
|
|
||
| - name: x |
There was a problem hiding this comment.
This property is not on the scale event in iOS.
|
Docs reviewed. Please address comments. |
| type: Number | ||
|
|
||
| - name: setContentOffset |
There was a problem hiding this comment.
Android does not have setContentOffset. However, there is a scrollToBottom() method.
There was a problem hiding this comment.
Fixed in next update.
|
Code reviewed, left a couple of comments. |
|
Updated. Please review. |
| - name: y | ||
| summary: Y coordinate of the event from the `source` view's coordinate system. | ||
| - name: x | ||
| summary: X coordinate of the event from the `source` view's coordinate system. |
There was a problem hiding this comment.
x & y should not be removed. This still exists in android.
There was a problem hiding this comment.
ignore this comment, didn't see it below.
|
Code reviewed and functionally tested. Request Accepted |
| summary: disable view bouncing. | ||
| summary: Determines whether all scroll bounce of the scrollable region is enabled. | ||
| description: | | ||
| Set to `true` to disable vertical bounce. |
There was a problem hiding this comment.
Also disables horizontal bounce.
There was a problem hiding this comment.
Addressed in next update.
|
Docs reviewed; please address comments. Looks like I was wrong about some of the initial information for bounce parameters. |
|
Updated. Please review. |
|
|
||
| #### Scrolling and Dragging | ||
|
|
||
| This view supports two types of gesturedrag is when your finger is still on the scroll view and you are physically dragging it versus the scrolling which is due to momentum (you scrolled the view with your finger, lifted your finger and the view cotinues to move) |
There was a problem hiding this comment.
Space/punctuation needed in gesturedrag
There was a problem hiding this comment.
May want a comma in here; dragging it, versus the
There was a problem hiding this comment.
Sorry, Stephen, I didn't mean to leave this in there. I've explained this in the events.
Fixed in next update.
|
Docs reviewed, additional comments |
|
Updated. Please review. |
|
Docs reviewed, APPROVED. |
|
Code reviewed and functionally tested. Request Accepted |
[TIDOC-414] [TIDOC-120] [TIDOC-245] [TIDOC-188] APIDoc: UI.ScrollView rewrite
https://jira.appcelerator.org/browse/TIDOC-414
https://jira.appcelerator.org/browse/TIDOC-120
https://jira.appcelerator.org/browse/TIDOC-245
https://jira.appcelerator.org/browse/TIDOC-188