Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-8559]Ensure windows in nav group have parentVisible=YES #1969

Merged
merged 2 commits into from
Apr 11, 2012
Merged

[TIMOB-8559]Ensure windows in nav group have parentVisible=YES #1969

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9220c66
[TIMOB-8559]Ensure windows in nav group have parentVisible=YES
vishalduggal Apr 10, 2012
908dbd6
Update comment
vishalduggal Apr 10, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion iphone/Classes/TiUIiPhoneNavigationGroup.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,11 @@ - (void)navigationController:(UINavigationController *)navigationController will
{
TiWindowProxy *newWindow = (TiWindowProxy *)[(TiViewController*)viewController proxy];
[newWindow setupWindowDecorations];

[newWindow windowWillOpen];
//TIMOB-8559. PR 1819 caused a regression that exposed an IOS issue. In IOS 5 and later, the nav controller calls
//UIViewControllerDelegate methods, but not in IOS 4.X. As a result the parentVisible flag is never flipped to true
//and the window never lays out. Using this method sets the flag and ensures window goes into layout queue.
[newWindow parentWillShow];
}
- (void)navigationController:(UINavigationController *)navigationController didShowViewController:(UIViewController *)viewController animated:(BOOL)animated
{
Expand Down