[TIMOB-7773]iOS: Back/close animation broken when a NavigationGroup is in a TabGroup #2295
Conversation
…tates to children
| @@ -1162,6 +1162,31 @@ -(void)viewDidDetach | |||
| // for subclasses | |||
| } | |||
|
|
|||
| -(void)parentWillAppear:(id)args | |||
There was a problem hiding this comment.
Seems like these methods should not be triggered until after the current view appears/disappears, or there could be issues where a view thinks its parent is visible before it's on screen. Probably should behave like TiUIWindow below.
There was a problem hiding this comment.
These methods are tied to the ViewControllers view(Will/Did)(Appear/Disappear) calls. They are always initiated from the TiUIWindow class.
|
@vishalduggal Code reviewed, please address comments. |
|
Encapsulated the state propagation in a viewAttached check. Ready for re-review |
|
Code reviewed, APPROVED. Not quite sure about whether or not the view attachment is required after all, but it seems like a good safety check since views are accessed during the parent visible chain. |
|
Tested, iPhone Sim 5.1. Light KS smoke and JIRA test. Passed, APPROVED. |
[TIMOB-7773]iOS: Back/close animation broken when a NavigationGroup is in a TabGroup
Test is in JIRA