Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-3215]Make the topmost Parent ScrollView handle the keyboardevents #2341

Merged
merged 4 commits into from
Jun 12, 2012

Conversation

srahim
Copy link
Contributor

@srahim srahim commented Jun 6, 2012

Test case in Jira

Test for regression on the following tickets:
TIMOB-5100
TIMOB-7998
TIMOB-8363
TIMOB-8368
TIMOB-8417

@srahim
Copy link
Contributor Author

srahim commented Jun 7, 2012

there might be regression, hold off on testing till next update. Have to do some more regression testing.

@srahim
Copy link
Contributor Author

srahim commented Jun 7, 2012

Updated ready for processing.

1 similar comment
@srahim
Copy link
Contributor Author

srahim commented Jun 7, 2012

Updated ready for processing.

@sptramer
Copy link
Contributor

sptramer commented Jun 8, 2012

Code reviewed, APPROVED.

@sptramer
Copy link
Contributor

sptramer commented Jun 8, 2012

Functional tested, iPhone Sim 5.1 and iPod 3GT 4.3.5.

TIMOB-3215: Pass
TIMOB-5100: FAILED: When rotating from portrait->landscape on iPod 3GT 4.3.5, the toolbar does not resize correctly
TIMOB-7998: Pass
TIMOB-8363: Pass (3GT 4.3.5 - no 4.0.2 to test)
TIMOB-8368: Pass
TIMOB-8417: Cannot test (no phys keyboard)

@srahim
Copy link
Contributor Author

srahim commented Jun 9, 2012

Updated... i suggest that the testing is done by somebody local in MV office because of the various device requirements.

@vishalduggal
Copy link
Contributor

Code Reviewed. ACCEPTED

@vishalduggal
Copy link
Contributor

Functional tested IOS Sim (4.3, 5.0, 5.1), iPOD (4.3.5 and 4.0.2) and iPAD2 (5.1)
All tests passed with the exception of TIMOB-7998 occasionally failing on iPOD 3rd gen with 4.0.2.

Accepting PR since this bug exists on the 2.0.2 GA release on this device as well and is not considered a regression.

ACCEPTED

vishalduggal added a commit that referenced this pull request Jun 12, 2012
[TIMOB-3215]Make the topmost Parent ScrollView handle the keyboardevents
@vishalduggal vishalduggal merged commit 3cc62f0 into tidev:master Jun 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants