Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-8471]iOS: VideoPlayer doesnot play with local file on iOS5 and above. #2357

Merged
merged 2 commits into from
Jun 12, 2012

Conversation

srahim
Copy link
Contributor

@srahim srahim commented Jun 8, 2012

It seems like on iOS 5 and above, the notification does not seem to be firing properly.

Was able to reproduce this issue on Xcode 4.3 and 4.2 on iOS 5.0 and above.

Test case in JIRA

@vishalduggal
Copy link
Contributor

Code reviewed. REJECTED.
The correct fix is to call [movie prepareToPlay] in the ensurePlayer method.

Look at discussion regarding the initWithContentURL: method of the MPMoviePlayerController.
http://developer.apple.com/library/ios/#documentation/mediaplayer/reference/MPMoviePlayerController_Class/Reference/Reference.html

@srahim
Copy link
Contributor Author

srahim commented Jun 12, 2012

Code updated according to review comments. Ready for rereview

@vishalduggal
Copy link
Contributor

Code reviewed. ACCEPTED

@vishalduggal
Copy link
Contributor

Functional passed. ACCEPTED

vishalduggal added a commit that referenced this pull request Jun 12, 2012
[TIMOB-8471]iOS: VideoPlayer doesnot play with local file on iOS5 and above.
@vishalduggal vishalduggal merged commit e58b3d2 into tidev:master Jun 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants