TIMOB-10031 support additional configs to make sure test pass includes r... #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s rhino. also includes 4 suites that were not included in the driver test porting
|
Code reviewed, APPROVED. |
|
Functional tested, iOS. Passed (tests ran to completion), APPROVED. |
|
CR/FR accepted. FR proved that Rhino was working and that there was the expected difference in results between rhino and V8 in the XML suite results. |
| backgroundColor : 'green', | ||
| borderRadius : 10, | ||
| width : 200, | ||
| height : 200, |
|
Looks good. Code reviewed and functionally tested for mobile web. Request ACCEPTED. |
cb1kenobi
added a commit
that referenced
this pull request
Jul 25, 2012
TIMOB-10031 support additional configs to make sure test pass includes r...
|
Hey Opie, I'm using https://jira.appcelerator.org/browse/TIMOB-8214 for a quick jira test, it is an invalid issue. I will remove the test link when finished, thanks. Dustin Hyde Associate Quality Engineer Appcelerator, Inc. dhyde@appcelerator.commailto:dhyde@appcelerator.com http://www.appcelerator.comhttp://www.appcelerator.com/ [unknown.png] The Next Generation Mobile Platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...hino. also includes 4 suites that were not included in the driver test porting
https://jira.appcelerator.org/browse/TIMOB-10031
Testing for this PR is just doing a full anvil pass on all 3 platforms. Make sure that the XML, both ui layout suites and the util suite all run.
This is porting effort rather than new development for the vast majority. Old tests left in Drillbit for a while until we are all comfortable rolling them out of the repo.