Timob 9825-2_1_X: Android animations need to accept unit specifiers such as "dp" #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idth/height Conflicts: android/titanium/src/java/org/appcelerator/titanium/util/TiAnimationBuilder.java
|
Code reviewed and functionally tested. The 2.3 left some artifacts when animating, but this is a known issue. The app no longer crashes when using dp values. Request Accepted |
ayeung
pushed a commit
that referenced
this pull request
Aug 16, 2012
Timob 9825-2_1_X: Android animations need to accept unit specifiers such as "dp"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JIRA item.
This is the 2_1_X cherry-pick of #2606