[TIMOB-10041] iOS: Implementing trackSignificantLocationChange for Geolocation Module #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Reviewed. ACCEPTED |
|
Updated code . Ready for Re-review. |
|
Code Reviewed and functionally tested on iPhone 4 (5.0). ACCEPTED |
vishalduggal
added a commit
that referenced
this pull request
Aug 16, 2012
[TIMOB-10041] iOS: Implementing trackSignificantLocationChange for Geolocation Module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing instruction in JIRA.
*** The only actual noticeable difference i saw when using method is that heading starts firing more often(even for the most minute change) and location update is fired only when you change cellular radio tower.(good luck with testing that.)
Will make a KS ticket to add this new feature if this is accepted.