Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-10565] fixed all text in TextField being treated like hintText #2850

Closed
wants to merge 1 commit into from
Closed

[TIMOB-10565] fixed all text in TextField being treated like hintText #2850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions mobileweb/titanium/Ti/_/UI/TextBox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,10 @@ define(
return this._showingHint ? "" : this._field.value;
},
set: function(value) {
this._showingHint = (value === "");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this short-circuits the logic in TextField. The _updateHint method is the only method that should change the value of showingHint.

return this._capitalize(this._field.value = value);
},
post: "_updateHint",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_updateHint is a method on the child class TextField, meaning that this will code will crash if you use a TextArea.

value: ""
}
}
Expand Down