Timob 10462 #3114
Merged
Timob 10462 #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: iphone/iphone/Titanium.xcodeproj/project.pbxproj
…art is setting up the section relationship.
ghost
assigned 
|
Code Reviewed. ACCEPTED |
|
This PR does not change existing functionality. Just sets the building blocks to fix our eventing architecture |
|
FR Passed. Could easily verify the cancelBubble and bubbleParent properties for event and view respectively. |
| event->pendingEvents = runloopcount; | ||
| if (runloopcount == 1) { //Main case: One run loop. | ||
| TiBindingRunLoop ourRunLoop = [targetProxy primaryBindingRunLoop]; | ||
| if (ourRunLoop != nil) { // It's possible that |
There was a problem hiding this comment.
where you in the middle of a comment?
|
Minor comment changes required. Code wise everything looks good. |
|
Ran docgen.py and validate.py APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test is in KS and in Jira. Timob 10462