Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-11285] (3_0_X) Opening a new window must always dismiss keyboard #3292

Merged
merged 1 commit into from
Oct 18, 2012
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion iphone/Classes/TiUITabProxy.m
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#import "TiUITabGroupProxy.h"
#import "TiUtils.h"
#import "ImageLoader.h"
#import "TiApp.h"


//NOTE: this proxy is a little different than normal Proxy/View pattern
Expand Down Expand Up @@ -279,7 +280,7 @@ -(void)open:(NSArray*)args
[window setParentOrientationController:self];
// TODO: Slap patch. Views, when opening/added, should check parent visibility (and parent/parent visibility, if possible)
[window parentWillShow];

[[[TiApp app] controller] dismissKeyboard];
TiThreadPerformOnMainThread(^{
[self openOnUIThread:args];
}, YES);
Expand Down
2 changes: 2 additions & 0 deletions iphone/Classes/TiUIiPhoneNavigationGroupProxy.m
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#import "TiUtils.h"
#import "TiWindowProxy.h"
#import "TiUIiPhoneNavigationGroup.h"
#import "TiApp.h"

@implementation TiUIiPhoneNavigationGroupProxy

Expand All @@ -31,6 +32,7 @@ -(void)open:(NSArray*)args
[self rememberProxy:window];

ENSURE_UI_THREAD(open, args);
[[[TiApp app] controller] dismissKeyboard];
NSDictionary *properties = [args count] > 1 ? [args objectAtIndex:1] : [NSDictionary dictionary];
[[self view] performSelector:@selector(open:withObject:) withObject:window withObject:properties];
}
Expand Down