Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-12173] Remove requirement that the app id must be all lower case. #3723

Merged
merged 1 commit into from
Jan 19, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion iphone/cli/hooks/install.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ exports.init = function (logger, config, cli) {
function (next) {
var pkgapp = path.join(build.xcodeEnv.path, 'Platforms', 'iPhoneOS.platform', 'Developer', 'usr', 'bin', 'PackageApplication');
if (afs.exists(pkgapp)) {
exec(pkgapp + ' "' + build.xcodeAppDir + '"', function (err, stdout, stderr) {
exec('"' + pkgapp + '" "' + build.xcodeAppDir + '"', function (err, stdout, stderr) {
if (err) {
logger.warn(__('An error occurred running the iOS Package Application tool'));
stderr.split('\n').forEach(logger.debug);
Expand Down
8 changes: 4 additions & 4 deletions support/cli/commands/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ exports.config = function (logger, config, cli) {
if (!id) {
throw new appc.exception(__('Invalid app id'));
}
if (!/^([a-z_]{1}[a-z0-9_]*(\.[a-z_]{1}[a-z0-9_]*)*)$/.test(id)) {
if (!/^([a-zA-Z_]{1}[a-zA-Z0-9_]*(\.[a-zA-Z_]{1}[a-zA-Z0-9_]*)*)$/.test(id)) {
throw new appc.exception(__('Invalid app id "%s"', id), [
__('The app id must consist of lower case letters, numbers, and underscores.'),
__('The app id must consist of letters, numbers, and underscores.'),
__('The first character must be a letter or underscore.'),
__("Usually the app id is your company's reversed Internet domain name. (i.e. com.example.myapp)")
]);
Expand Down Expand Up @@ -136,9 +136,9 @@ exports.validate = function (logger, config, cli) {
}

cli.argv.id = (cli.argv.id || '').trim();
if (!/^([a-z_]{1}[a-z0-9_]*(\.[a-z_]{1}[a-z0-9_]*)*)$/.test(cli.argv.id)) {
if (!/^([a-zA-Z_]{1}[a-zA-Z0-9_]*(\.[a-zA-Z_]{1}[a-zA-Z0-9_]*)*)$/.test(cli.argv.id)) {
logger.error(__('Invalid app id "%s"', cli.argv.id) + '\n');
logger.log(__('The app id must consist of lower case letters, numbers, and underscores.'));
logger.log(__('The app id must consist of letters, numbers, and underscores.'));
logger.log(__('The first character must be a letter or underscore.'));
logger.log(__("Usually the app id is your company's reversed Internet domain name. (i.e. com.example.myapp)") + '\n');
process.exit(1);
Expand Down
6 changes: 3 additions & 3 deletions support/node_modules/titanium-sdk/lib/titanium.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.