Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-12420] Change debug() calls to info() for iOS full rebuild checks #3777

Closed
wants to merge 12 commits into from
Closed

[TIMOB-12420] Change debug() calls to info() for iOS full rebuild checks #3777

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
17e40d0
[TIMOB-10330] Fix up background Color initialization for iOS6
vishalduggal Oct 10, 2012
b4ca70c
[TIMOB-11328] Fixed the description of the clean command.
cb1kenobi Oct 9, 2012
8d03803
[TIMOB-11317] Fixed missing dependencies in Ti.Media.AudioPlayer and …
cb1kenobi Oct 10, 2012
3566fce
Merge pull request #3151 from vishalduggal/timob-11300-30X
srahim Oct 10, 2012
6c9a618
Merge pull request #3156 from cb1kenobi/timob-11317_3_0_X
Oct 10, 2012
e042d45
Merge pull request #3153 from cb1kenobi/timob-11328_3_0_X
Oct 10, 2012
a828513
Merge branch '3_0_X' of git://github.com/appcelerator/titanium_mobile
tonylukasavage Oct 10, 2012
474c245
Merge branch 'master' of git://github.com/appcelerator/titanium_mobile
tonylukasavage Nov 6, 2012
faef401
Merge branch 'master' of git://github.com/appcelerator/titanium_mobile
tonylukasavage Nov 13, 2012
6cd8ad0
Merge branch 'master' of git://github.com/appcelerator/titanium_mobile
tonylukasavage Nov 15, 2012
51f6821
Merge branch 'master' of git://github.com/appcelerator/titanium_mobile
tonylukasavage Jan 24, 2013
e50af6b
[TIMOB-12420] Changed debug() calls to info() for iOS full rebuild ch…
tonylukasavage Jan 24, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
102 changes: 51 additions & 51 deletions iphone/cli/commands/_build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,13 +1345,13 @@ build.prototype = {
var manifest = this.buildManifest;

if (this.cli.argv.force) {
this.logger.debug(__('Forcing rebuild: %s flag was set', '--force'.cyan));
this.logger.info(__('Forcing rebuild: %s flag was set', '--force'.cyan));
return true;
}

if (!afs.exists(this.buildManifestFile)) {
// if no .version file, rebuild!
this.logger.debug(__('Forcing rebuild: %s does not exist', this.buildManifestFile.cyan));
this.logger.info(__('Forcing rebuild: %s does not exist', this.buildManifestFile.cyan));
return true;
}

Expand All @@ -1362,135 +1362,135 @@ build.prototype = {
idMatch = conf.match(/TI_APPID\=([^\n]*)/);

if (versionMatch && !appc.version.eq(versionMatch[1], this.titaniumSdkVersion)) {
this.logger.debug(__("Forcing rebuild: last build was under Titanium SDK version %s and we're compiling for version %s", versionMatch[1].cyan, this.titaniumSdkVersion.cyan));
this.logger.info(__("Forcing rebuild: last build was under Titanium SDK version %s and we're compiling for version %s", versionMatch[1].cyan, this.titaniumSdkVersion.cyan));
return true;
}

if (idMatch && idMatch[1] != this.tiapp.id) {
this.logger.debug(__("Forcing rebuild: app id changed from %s to %s", idMatch[1].cyan, this.tiapp.id.cyan));
this.logger.info(__("Forcing rebuild: app id changed from %s to %s", idMatch[1].cyan, this.tiapp.id.cyan));
return true;
}
}

if (!afs.exists(this.xcodeAppDir)) {
this.logger.debug(__('Forcing rebuild: %s does not exist', this.xcodeAppDir.cyan));
this.logger.info(__('Forcing rebuild: %s does not exist', this.xcodeAppDir.cyan));
return true;
}

// check that we have a libTiCore hash
if (!manifest.tiCoreHash) {
this.logger.debug(__('Forcing rebuild: incomplete version file %s', this.buildVersionFile.cyan));
this.logger.info(__('Forcing rebuild: incomplete version file %s', this.buildVersionFile.cyan));
return true;
}

// check if the libTiCore hashes are different
if (this.libTiCoreHash != manifest.tiCoreHash) {
this.logger.debug(__('Forcing rebuild: libTiCore hash changed since last build'));
this.logger.debug(' ' + __('Was: %s', manifest.tiCoreHash));
this.logger.debug(' ' + __('Now: %s', this.libTiCoreHash));
this.logger.info(__('Forcing rebuild: libTiCore hash changed since last build'));
this.logger.info(' ' + __('Was: %s', manifest.tiCoreHash));
this.logger.info(' ' + __('Now: %s', this.libTiCoreHash));
return true;
}

// check if the titanium sdk paths are different
if (manifest.iosSdkPath != this.titaniumIosSdkPath) {
this.logger.debug(__('Forcing rebuild: Titanium SDK path changed since last build'));
this.logger.debug(' ' + __('Was: %s', manifest.iosSdkPath));
this.logger.debug(' ' + __('Now: %s', this.titaniumIosSdkPath));
this.logger.info(__('Forcing rebuild: Titanium SDK path changed since last build'));
this.logger.info(' ' + __('Was: %s', manifest.iosSdkPath));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need the was/now as [info]?

this.logger.info(' ' + __('Now: %s', this.titaniumIosSdkPath));
return true;
}

// check if the device family has changed (i.e. was universal, now iphone)
if (manifest.deviceFamily != this.deviceFamily) {
this.logger.debug(__('Forcing rebuild: device family changed since last build'));
this.logger.debug(' ' + __('Was: %s', manifest.deviceFamily));
this.logger.debug(' ' + __('Now: %s', this.deviceFamily));
this.logger.info(__('Forcing rebuild: device family changed since last build'));
this.logger.info(' ' + __('Was: %s', manifest.deviceFamily));
this.logger.info(' ' + __('Now: %s', this.deviceFamily));
return true;
}

// check the git hashes are different
if (!manifest.gitHash || manifest.gitHash != ti.manifest.githash) {
this.logger.debug(__('Forcing rebuild: githash changed since last build'));
this.logger.debug(' ' + __('Was: %s', manifest.gitHash));
this.logger.debug(' ' + __('Now: %s', ti.manifest.githash));
this.logger.info(__('Forcing rebuild: githash changed since last build'));
this.logger.info(' ' + __('Was: %s', manifest.gitHash));
this.logger.info(' ' + __('Now: %s', ti.manifest.githash));
return true;
}

// check if the app guids are different
if (this.tiapp.guid != manifest.appGuid) {
this.logger.debug(__('Forcing rebuild: githash changed since last build'));
this.logger.debug(' ' + __('Was: %s', manifest.appGuid));
this.logger.debug(' ' + __('Now: %s', this.tiapp.guid));
this.logger.info(__('Forcing rebuild: githash changed since last build'));
this.logger.info(' ' + __('Was: %s', manifest.appGuid));
this.logger.info(' ' + __('Now: %s', this.tiapp.guid));
return true;
}

// check if the modules hashes are different
if (this.modulesHash != manifest.modulesHash) {
this.logger.debug(__('Forcing rebuild: modules hash changed since last build'));
this.logger.debug(' ' + __('Was: %s', manifest.modulesHash));
this.logger.debug(' ' + __('Now: %s', this.modulesHash));
this.logger.info(__('Forcing rebuild: modules hash changed since last build'));
this.logger.info(' ' + __('Was: %s', manifest.modulesHash));
this.logger.info(' ' + __('Now: %s', this.modulesHash));
return true;
}

// next we check if any tiapp.xml values changed so we know if we need to reconstruct the main.m
if (this.tiapp.name != manifest.name) {
this.logger.debug(__('Forcing rebuild: tiapp.xml project name changed since last build'));
this.logger.debug(' ' + __('Was: %s', manifest.name));
this.logger.debug(' ' + __('Now: %s', this.tiapp.name));
this.logger.info(__('Forcing rebuild: tiapp.xml project name changed since last build'));
this.logger.info(' ' + __('Was: %s', manifest.name));
this.logger.info(' ' + __('Now: %s', this.tiapp.name));
return true;
}

if (this.tiapp.id != manifest.id) {
this.logger.debug(__('Forcing rebuild: tiapp.xml app id changed since last build'));
this.logger.debug(' ' + __('Was: %s', manifest.id));
this.logger.debug(' ' + __('Now: %s', this.tiapp.id));
this.logger.info(__('Forcing rebuild: tiapp.xml app id changed since last build'));
this.logger.info(' ' + __('Was: %s', manifest.id));
this.logger.info(' ' + __('Now: %s', this.tiapp.id));
return true;
}

if (!this.tiapp.analytics != !manifest.analytics) {
this.logger.debug(__('Forcing rebuild: tiapp.xml analytics flag changed since last build'));
this.logger.debug(' ' + __('Was: %s', !!manifest.analytics));
this.logger.debug(' ' + __('Now: %s', !!this.tiapp.analytics));
this.logger.info(__('Forcing rebuild: tiapp.xml analytics flag changed since last build'));
this.logger.info(' ' + __('Was: %s', !!manifest.analytics));
this.logger.info(' ' + __('Now: %s', !!this.tiapp.analytics));
return true;
}
if (this.tiapp.publisher != manifest.publisher) {
this.logger.debug(__('Forcing rebuild: tiapp.xml publisher changed since last build'));
this.logger.debug(' ' + __('Was: %s', manifest.publisher));
this.logger.debug(' ' + __('Now: %s', this.tiapp.publisher));
this.logger.info(__('Forcing rebuild: tiapp.xml publisher changed since last build'));
this.logger.info(' ' + __('Was: %s', manifest.publisher));
this.logger.info(' ' + __('Now: %s', this.tiapp.publisher));
return true;
}

if (this.tiapp.url != manifest.url) {
this.logger.debug(__('Forcing rebuild: tiapp.xml url changed since last build'));
this.logger.debug(' ' + __('Was: %s', manifest.url));
this.logger.debug(' ' + __('Now: %s', this.tiapp.url));
this.logger.info(__('Forcing rebuild: tiapp.xml url changed since last build'));
this.logger.info(' ' + __('Was: %s', manifest.url));
this.logger.info(' ' + __('Now: %s', this.tiapp.url));
return true;
}

if (this.tiapp.version != manifest.version) {
this.logger.debug(__('Forcing rebuild: tiapp.xml version changed since last build'));
this.logger.debug(' ' + __('Was: %s', manifest.version));
this.logger.debug(' ' + __('Now: %s', this.tiapp.version));
this.logger.info(__('Forcing rebuild: tiapp.xml version changed since last build'));
this.logger.info(' ' + __('Was: %s', manifest.version));
this.logger.info(' ' + __('Now: %s', this.tiapp.version));
return true;
}

if (this.tiapp.description != manifest.description) {
this.logger.debug(__('Forcing rebuild: tiapp.xml description changed since last build'));
this.logger.debug(' ' + __('Was: %s', manifest.description));
this.logger.debug(' ' + __('Now: %s', this.tiapp.description));
this.logger.info(__('Forcing rebuild: tiapp.xml description changed since last build'));
this.logger.info(' ' + __('Was: %s', manifest.description));
this.logger.info(' ' + __('Now: %s', this.tiapp.description));
return true;
}

if (this.tiapp.copyright != manifest.copyright) {
this.logger.debug(__('Forcing rebuild: tiapp.xml copyright changed since last build'));
this.logger.debug(' ' + __('Was: %s', manifest.copyright));
this.logger.debug(' ' + __('Now: %s', this.tiapp.copyright));
this.logger.info(__('Forcing rebuild: tiapp.xml copyright changed since last build'));
this.logger.info(' ' + __('Was: %s', manifest.copyright));
this.logger.info(' ' + __('Now: %s', this.tiapp.copyright));
return true;
}

if (this.tiapp.guid != manifest.guid) {
this.logger.debug(__('Forcing rebuild: tiapp.xml guid changed since last build'));
this.logger.debug(' ' + __('Was: %s', manifest.guid));
this.logger.debug(' ' + __('Now: %s', this.tiapp.guid));
this.logger.info(__('Forcing rebuild: tiapp.xml guid changed since last build'));
this.logger.info(' ' + __('Was: %s', manifest.guid));
this.logger.info(' ' + __('Now: %s', this.tiapp.guid));
return true;
}

Expand Down