Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIMOB-11282: Android TableView with remote images is very slow #3780

Merged
merged 4 commits into from
Jan 29, 2013
Merged

TIMOB-11282: Android TableView with remote images is very slow #3780

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
efecd5a
TIMOB-11282: keep one background task alive per image view
pingwang2011 Jan 24, 2013
1a6ed0e
timob-11282: address comment
pingwang2011 Jan 28, 2013
041cc95
timob-11282: fix the code style
pingwang2011 Jan 28, 2013
e3e6cc4
timob-11282: remove unnecessary import
pingwang2011 Jan 28, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
161 changes: 85 additions & 76 deletions android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIImageView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import java.util.Timer;
import java.util.TimerTask;
import java.util.concurrent.ArrayBlockingQueue;
import java.util.concurrent.RejectedExecutionException;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;

Expand Down Expand Up @@ -85,7 +86,7 @@ public class TiUIImageView extends TiUIView implements OnLifecycleEvent, Handler
private int decodeRetries = 0;
private Object releasedLock = new Object();
private String currentUrl;

final class ImageDownloadListener implements TiDownloadListener {
public int mToken;
public ImageArgs mImageArgs;
Expand Down Expand Up @@ -123,7 +124,11 @@ public void downloadFinished(URI uri)
true,
false);
BackgroundImageTask task = new BackgroundImageTask();
task.execute(imageArgs);
try {
task.execute(imageArgs);
} catch (RejectedExecutionException e) {
Log.e(TAG, "Cannot load the image. Loading too many images at the same time.");
}
}
}
}
Expand Down Expand Up @@ -747,79 +752,75 @@ public ImageArgs(TiDrawableReference imageref, View view,

}
}

final class BackgroundImageTask extends AsyncTask<ImageArgs, Void, Bitmap> {

final class BackgroundImageTask extends AsyncTask<ImageArgs, Void, Bitmap>
{
private boolean recycle;
private boolean mNetworkURL;
private boolean mAsync = false;
private String mUrl;

@Override
protected Bitmap doInBackground(final ImageArgs... params) {
final ImageArgs imageArgs = params[0];

recycle = imageArgs.mRecycle;
mNetworkURL = imageArgs.mNetworkURL;
Bitmap bitmap = null;

mUrl = imageArgs.mImageref.getUrl();

if (mNetworkURL) {
boolean getAsync = true;
try {
String imageUrl = TiUrl.getCleanUri(imageArgs.mImageref.getUrl()).toString();

URI uri = new URI(imageUrl);
getAsync = !TiResponseCache.peek(uri); // expensive, don't want to do in UI thread
} catch (URISyntaxException e) {
Log.e(TAG, "URISyntaxException for url " + imageArgs.mImageref.getUrl(), e);
getAsync = false;
} catch (NullPointerException e) {
Log.e(TAG, "NullPointerException for url " + imageArgs.mImageref.getUrl(), e);
getAsync = false;
} catch (Exception e) {
Log.e(TAG, "Caught exception for url" + imageArgs.mImageref.getUrl(), e);
}
if (getAsync) {
//
// We've got to start the download back on the UI thread, if we do it on one
// of the AsyncTask threads it will throw an exception.
//
mAsync = true;

TiMessenger.getMainMessenger().post(new Runnable()
{
@Override
public void run()
{
imageArgs.mImageref.getBitmapAsync(imageDownloadListener);

}
});

} else {
bitmap = (imageArgs.mImageref).getBitmap(
imageArgs.mView,
imageArgs.mRequestedWidth,
imageArgs.mRequestedHeight);
}
}
else {
bitmap = (imageArgs.mImageref).getBitmap(
imageArgs.mView,
imageArgs.mRequestedWidth,
imageArgs.mRequestedHeight);
}
return bitmap;
}

@Override
protected void onPostExecute(Bitmap result) {
if (!mNetworkURL || currentUrl.equals(mUrl)) {
if (result != null) {

setImage(result);


@Override
protected Bitmap doInBackground(final ImageArgs... params)
{
final ImageArgs imageArgs = params[0];

recycle = imageArgs.mRecycle;
mNetworkURL = imageArgs.mNetworkURL;
Bitmap bitmap = null;

mUrl = imageArgs.mImageref.getUrl();

if (mNetworkURL) {
boolean getAsync = true;
try {
String imageUrl = TiUrl.getCleanUri(imageArgs.mImageref.getUrl()).toString();

URI uri = new URI(imageUrl);
getAsync = !TiResponseCache.peek(uri); // expensive, don't want to do in UI thread
} catch (URISyntaxException e) {
Log.e(TAG, "URISyntaxException for url " + imageArgs.mImageref.getUrl(), e);
getAsync = false;
} catch (NullPointerException e) {
Log.e(TAG, "NullPointerException for url " + imageArgs.mImageref.getUrl(), e);
getAsync = false;
} catch (Exception e) {
Log.e(TAG, "Caught exception for url" + imageArgs.mImageref.getUrl(), e);
}
if (getAsync) {
//
// We've got to start the download back on the UI thread, if we do it on one
// of the AsyncTask threads it will throw an exception.
//
mAsync = true;

TiMessenger.getMainMessenger().post(new Runnable()
{
@Override
public void run()
{
imageArgs.mImageref.getBitmapAsync(imageDownloadListener);

}
});

} else {
bitmap = (imageArgs.mImageref).getBitmap(imageArgs.mView, imageArgs.mRequestedWidth,
imageArgs.mRequestedHeight);
}
} else {
bitmap = (imageArgs.mImageref).getBitmap(imageArgs.mView, imageArgs.mRequestedWidth,
imageArgs.mRequestedHeight);
}
return bitmap;
}

@Override
protected void onPostExecute(Bitmap result)
{
if (!mNetworkURL || currentUrl.equals(mUrl)) {
if (result != null) {
setImage(result);
if (!firedLoad) {
fireLoad(TiC.PROPERTY_IMAGE);
firedLoad = true;
Expand All @@ -829,10 +830,10 @@ protected void onPostExecute(Bitmap result) {
retryDecode(recycle);
}
}
}
}
}
}
}

private void setImage(boolean recycle) {

if (imageSources == null || imageSources.size() == 0 || imageSources.get(0) == null || imageSources.get(0).isTypeNull()) {
Expand Down Expand Up @@ -870,7 +871,11 @@ private void setImage(boolean recycle) {
true);

BackgroundImageTask task = new BackgroundImageTask();
task.execute(imageArgs);
try {
task.execute(imageArgs);
} catch (RejectedExecutionException e) {
Log.e(TAG, "Cannot load the image. Loading too many images at the same time.");
}

} else {
currentUrl = imageref.getUrl();
Expand All @@ -879,7 +884,11 @@ private void setImage(boolean recycle) {
false);

BackgroundImageTask task = new BackgroundImageTask();
task.execute(imageArgs);
try {
task.execute(imageArgs);
} catch (RejectedExecutionException e) {
Log.e(TAG, "Cannot load the image. Loading too many images at the same time.");
}
}
} else {
setImages();
Expand Down