TIMOB-13055: Added row property for additional tableview events. #4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
FR Failed. When I click on the row I am getting the source property for touchstart and touchend as the tableView instead on the tableViewRow. Also what is the rationale of doing this in the tableView. Since all events bubble through the row proxy, wouldn't it be easier to just fill the data in the rowProxy? |
|
Code updated. Ready for review. |
| Item item = getTableView().getTableView().getItemAtPosition(index); | ||
| dataCopy.put(TiC.PROPERTY_SOURCE, item.proxy); | ||
| return item.proxy.fireEvent(eventName, dataCopy, bubbles); | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Missing super.fireEvent().
If the event comes here bit does not belong to a tableViewrow/section (Say longpress on headerView) we should still fire the event)
|
CR and FR ok. |
vishalduggal
added a commit
that referenced
this pull request
Apr 1, 2013
TIMOB-13055: Added row property for additional tableview events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-13055
Test case in Jira. Please also run docgen and validate on docs.