[TIMOB-13243] iOS: center wrapperview when required #4177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile into timob-13243
ghost
assigned 
|
Code Reviewed and APPROVED |
|
Code Reviewed and approved Functionally Tested and approved |
| contentSize.size.width = MAX(contentSize.size.width,viewBounds.size.width); | ||
| contentSize.size.height = MAX(contentSize.size.height,viewBounds.size.height); | ||
| //contentSize.size.width = MAX(contentSize.size.width,viewBounds.size.width); | ||
| //contentSize.size.height = MAX(contentSize.size.height,viewBounds.size.height); |
There was a problem hiding this comment.
If this is gone, delete it. Git history will know of its passing.
|
CR approved, minor quibble, but other than that, looks good. |
|
On Second look of KS .. we have a regression on ScrollView > ScrollView TextArea. |
|
Closing this PR. Causing too many regressions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TIMOB-13243
Regression Path
http://jira.appcelerator.org/browse/TIMOB-10330
http://jira.appcelerator.org/browse/TIMOB-7958
http://jira.appcelerator.org/browse/TIMOB-11610
http://jira.appcelerator.org/browse/TIMOB-11019
http://jira.appcelerator.org/browse/TIMOB-11707
http://jira.appcelerator.org/browse/TIMOB-11476
http://jira.appcelerator.org/browse/TIMOB-11477
http://jira.appcelerator.org/browse/TIMOB-11479
http://jira.appcelerator.org/browse/TIMOB-11377
KS->Base UI->Views->ScrollView