Timob 13796: Android: Implement new window architecture #4417
Conversation
1. If "ti.android.useLegacyWindow" is enabled in tiapp.xml, it follows old window behavior, including lightweight and heavryweight. 2. Otherwise, all windows are heavyweight. 3. Both heavyweight and lightweight windows use WindowProxy and use TiView to set their view. 4. Add support for activityEnter/ExitAnimation in close().
…e into timob-13796
…e anvil tests. Add new anvil tests.
ghost
assigned 
| @@ -411,6 +411,7 @@ public void postOnCreate() | |||
| } | |||
|
|
|||
| TiConfig.DEBUG = TiConfig.LOGD = systemProperties.getBool("ti.android.debug", false); | |||
| TiConfig.LEGACY_WINDOW = systemProperties.getBool("ti.android.useLegacyWindow", false); | |||
There was a problem hiding this comment.
We are trying to move away from using TiConfig. We should be using the systemProperties instead and not use TiConfig.
|
Code reviewed. Left comments. |
|
Update. |
| activity.overridePendingTransition(TiConvert.toInt(options.get(TiC.INTENT_PROPERTY_ENTER_ANIMATION), 0), | ||
| TiConvert.toInt(options.get(TiC.INTENT_PROPERTY_EXIT_ANIMATION), 0)); | ||
| } else { | ||
| activity.finish(); |
There was a problem hiding this comment.
We can probably just call activity.finish() before the if statement.
|
Testing up to 5c with the following results: KS Tests:
https://jira.appcelerator.org/browse/TIMOB-8648: Will wait until these issues are addressed before continuing. |
…top/bottom/left/right for HW windows.
|
Closed by mistake. Reopened. |
| if (lightweight) { | ||
| addLightweightWindowToStack(); | ||
| } else { | ||
| // The "top", "bottom", "left" and "right" properties do not work for heavyweight windows. |
There was a problem hiding this comment.
Has this ever worked for HW windows? The docs don't say anything about this not working. We may want to document this as such if it doesn't work for windows in android (since there is only one type of windows in the future).
There was a problem hiding this comment.
No, those properties never worked for HW windows. I will document it.
|
Code reviewed and functionally tested. Ran all the test cases mentioned including KS and anvil. Also ran docgen and validate. Request Accepted. |
Timob 13796: Android: Implement new window architecture
https://jira.appcelerator.org/browse/TIMOB-13796
Test steps in JIRA.