[TIMOB-4642] Fixed timed event not accepting Date. Cleaned up strings to #449
Conversation
… to constants. Fixed method brace formatting.
| if (stop instanceof Number) { | ||
| payload.put(TiC.PROPERTY_STOP, ((Number) stop).longValue()); | ||
| } else if (stop instanceof KrollDate) { | ||
| payload.put(TiC.PROPERTY_STOP, ((KrollDate) start).getTime()); |
There was a problem hiding this comment.
looks like you referenced "start" here, when you meant to reference "stop"
|
Functional review tentatively accepted. The API seems to be executed correctly now, but I'm not the best way to verify that the timed analytics event is actually sent |
|
Code review accepted, we need to get someone from QE / Cloud to verify the event is being sent correctly |
|
Request ACCEPTED |
|
Accepted based on code review and functional test. Did two func tests, one using Date objects, the other user using Long values of Date objects, e.g., |
[TIMOB-4642] Fixed timed event not accepting Date. Cleaned up strings to
[TIMOB-4642] Fixed timed event not accepting Date. Cleaned up strings to constants. Fixed method brace formatting.