Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test cases suite TiUiSlider #4865

Merged
merged 7 commits into from
Feb 11, 2014
Merged

test cases suite TiUiSlider #4865

merged 7 commits into from
Feb 11, 2014

Conversation

jithinv
Copy link
Contributor

@jithinv jithinv commented Oct 28, 2013

test cases:
sliderInTableViewRow
valueOnCreation

@lokeshchdhry
Copy link
Contributor

PR looks good. Functional tests work fine. No issues

{name: "valueOnCreation"}
]

//TIMOB-9672
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually a tableview issue. But i am fine either ways.

@srahim
Copy link
Contributor

srahim commented Jan 30, 2014

Just re-sync with master looks good to me .

@lokeshchdhry
Copy link
Contributor

Please try re synching with master again. I don't see the merge button enabled.

@lokeshchdhry
Copy link
Contributor

Functional tests passed on android & iOS . Merging.

lokeshchdhry pushed a commit that referenced this pull request Feb 11, 2014
test cases suite TiUiSlider
@lokeshchdhry lokeshchdhry merged commit f6ebe49 into tidev:master Feb 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants