anvil test case for kitchenSink/platform/passingWindow #5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
| w2.open(); | ||
| setTimeout(function() { | ||
| var win2 = require('suites/ui/win_2').get_prop(); |
There was a problem hiding this comment.
why is there a second required here ? if you declare w2 a global variable to the function. the variable should last till the timeout is fired.
|
minor rewrite required looks good otherwise. |
| @@ -558,4 +559,39 @@ module.exports = new function() { | |||
| }); | |||
| win.open(); | |||
| } | |||
|
|
|||
| //KitchenSink: Platform | |||
| this.passingWindow = function(testRun) { | |||
There was a problem hiding this comment.
why is the test called passingWIndow ???
|
Verified the suggested corrections. Please resync to master for merge. |
|
Merging. |
lokeshchdhry
pushed a commit
that referenced
this pull request
Feb 12, 2014
anvil test case for kitchenSink/platform/passingWindow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case:
passing window