Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-16257] add property and remove methods #5244

Closed
wants to merge 1 commit into from
Closed

[TIMOB-16257] add property and remove methods #5244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 2 additions & 13 deletions android/modules/ui/src/java/ti/modules/titanium/ui/ScrollViewProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
TiC.PROPERTY_SCROLL_TYPE,
TiC.PROPERTY_CONTENT_OFFSET,
TiC.PROPERTY_CAN_CANCEL_EVENTS,
TiC.PROPERTY_OVER_SCROLL_MODE
TiC.PROPERTY_OVER_SCROLL_MODE,
TiC.PROPERTY_SCROLLING_ENABLED
})
public class ScrollViewProxy extends TiViewProxy
implements Handler.Callback
Expand Down Expand Up @@ -72,18 +73,6 @@ public void scrollTo(int x, int y) {
}
}

@Kroll.setProperty @Kroll.method
public void setScrollingEnabled(Object enabled)
{
getScrollView().setScrollingEnabled(enabled);
}

@Kroll.getProperty @Kroll.method
public boolean getScrollingEnabled()
{
return getScrollView().getScrollingEnabled();
}

@Kroll.method
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. Why are you deleting these methods? They seem fine. If you want to add this as an accessor, you need to handle the property in processProperties and propertyChanged.

public void scrollToBottom() {
if (!TiApplication.isUIThread()) {
Expand Down