[TIMOB-1555][TIMOB-13294] iOS: Shadows and clipping on Views #5367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… explicit rules for clipping behavior when clipMode undefined or default.
…e into timob-1555
|
Parts of this PR are based on contributions by Martin Guillon |
This was referenced Feb 23, 2014
|
Reviewed and ran doc scripts. DR approved. |
|
Code Reviewed and APPROVED |
|
Functionally Reviewed and ACCEPTED |
|
Have a minor question for vishal. Does this introduce new behavior where if you have a child and clipsToBounds is not set . If you apply border shadow the child is not clipped anymore . Is this the accepted behavior ? |
|
Yes that is acceptable behavior since by default clipMode is set to default which means it is inferred |
pec1985
added a commit
that referenced
this pull request
Mar 3, 2014
[TIMOB-1555][TIMOB-13294] iOS: Shadows and clipping on Views
farfromrefug
pushed a commit
to Akylas/titanium_mobile
that referenced
this pull request
Aug 15, 2014
[TIMOB-1555][TIMOB-13294] iOS: Shadows and clipping on Views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following New Feature requests
TIMOB-1555
TIMOB-13294
Test using KS PR 142