Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timob-16538: Android: Analytics crashes App intermittently onResume #5908

Merged
merged 2 commits into from
Jul 16, 2014
Merged

timob-16538: Android: Analytics crashes App intermittently onResume #5908

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c9807d
timob-16538: Re-launch the app if the app has been killed by Android.
pingwang2011 Jul 11, 2014
bbe39d9
Merge branch 'master' of git://github.com/appcelerator/titanium_mobil…
pingwang2011 Jul 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 10 additions & 7 deletions android/titanium/src/java/org/appcelerator/titanium/TiBaseActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,11 +464,11 @@ protected void onCreate(Bundle savedInstanceState)
return;
}

// If all the activities has been killed and the runtime has been disposed, we cannot recover one
// specific activity because the info of the top-most view proxy has been lost (TiActivityWindows.dispose()).
// In this case, we have to restart the app.
// If all the activities has been killed and the runtime has been disposed or the app's hosting process has
// been killed, we cannot recover one specific activity because the info of the top-most view proxy has been
// lost (TiActivityWindows.dispose()). In this case, we have to restart the app.
if (TiBaseActivity.isUnsupportedReLaunch(this, savedInstanceState)) {
Log.w(TAG, "Runtime has been disposed. Finishing.");
Log.w(TAG, "Runtime has been disposed or app has been killed. Finishing.");
super.onCreate(savedInstanceState);
tiApp.scheduleRestart(250);
finish();
Expand Down Expand Up @@ -1393,9 +1393,12 @@ public void activityOnCreate(Bundle savedInstanceState)
*/
public static boolean isUnsupportedReLaunch(Activity activity, Bundle savedInstanceState)
{
// If all the activities has been killed and the runtime has been disposed, we have to relaunch
// the app.
if (KrollRuntime.isDisposed() && savedInstanceState != null && !(activity instanceof TiLaunchActivity)) {
// We have to relaunch the app if
// 1. all the activities have been killed and the runtime has been disposed or
// 2. the app's hosting process has been killed. In this case, onDestroy or any other method
// is not called. We can check the status of the root activity to detect this situation.
if (savedInstanceState != null && !(activity instanceof TiLaunchActivity) &&
(KrollRuntime.isDisposed() || TiApplication.getInstance().rootActivityLatch.getCount() != 0)) {
return true;
}
return false;
Expand Down