Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-17676] Added call to iOS api to reset separator insets #6091

Merged
merged 4 commits into from
Oct 3, 2014
Merged

[TIMOB-17676] Added call to iOS api to reset separator insets #6091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0bfc20
Added call to iOS api to reset separator insets
Sep 16, 2014
d55be5e
Merge branch 'master' of https://github.com/appcelerator/titanium_mob…
muhammaddadu Sep 16, 2014
c1d92a1
Merge branch 'master' of https://github.com/appcelerator/titanium_mob…
muhammaddadu Oct 3, 2014
d86c672
[TIMOB-17676] Code refactor
muhammaddadu Oct 3, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions iphone/Classes/TiUIListView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,11 @@ - (UITableView *)tableView
if ([TiUtils isIOS7OrGreater]) {
_defaultSeparatorInsets = [_tableView separatorInset];
}

if ([TiUtils isIOS8OrGreater]) {
[_tableView setLayoutMargins:UIEdgeInsetsZero];
}

}
if ([_tableView superview] != self) {
[self addSubview:_tableView];
Expand Down Expand Up @@ -1234,6 +1239,11 @@ - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(N
[cellProxy unarchiveFromTemplate:template];
}
}

if ([TiUtils isIOS8OrGreater] && (tableView == _tableView)) {
[cell setLayoutMargins:UIEdgeInsetsZero];
}

[cellProxy release];
[cell autorelease];
}
Expand Down
10 changes: 9 additions & 1 deletion iphone/Classes/TiUITableView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,10 @@ -(UITableView*)tableView
if ([TiUtils isIOS7OrGreater]) {
defaultSeparatorInsets = [tableview separatorInset];
}

if ([TiUtils isIOS8OrGreater]) {
[tableview setLayoutMargins:UIEdgeInsetsZero];
}
}
if ([tableview superview] != self)
{
Expand Down Expand Up @@ -2059,7 +2063,11 @@ - (UITableViewCell *)tableView:(UITableView *)ourTableView cellForRowAtIndexPath
[(TiUITableViewCell*)cell setProxy:row];
[row setCallbackCell:(TiUITableViewCell*)cell];
}
[row initializeTableViewCell:cell];
[row initializeTableViewCell:cell];

if ([TiUtils isIOS8OrGreater] && (tableview == ourTableView)) {
[cell setLayoutMargins:UIEdgeInsetsZero];
}

return cell;
}
Expand Down