[TIMOB-16697] Titanium Project cleanup #6269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, YES); | ||
| return blob; | ||
| DEPRECATED_REPLACED_REMOVED(@"Media.VideoPlayer.thumbnailImageAtTime",@"3.4.2",@"3.5.0",@"Media.VideoPlayer.requestThumbnailImagesAtTimes") | ||
| return nil; |
|
I would like to revert the removal of deprecated properties in this PR so that it can be merged into 3.4.2. We can then officially remove them in 3.5.0 |
| if (minFontSize > 4) { | ||
| CGFloat ratio = minFontSize/label.font.pointSize; | ||
| [label setMinimumScaleFactor:ratio]; | ||
| } |
|
This PR does not remove them. Just marks them as deprecated and candidates for removal in 3.5.0 |
|
CR & FT pass |
jonalter
added a commit
that referenced
this pull request
Oct 24, 2014
[TIMOB-16697] Titanium Project cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the deployment target on Titanium projects from 5.0 to 7.0
It enforces our min-ios-ver support of 7.0 (3.4.0 and 3.4.1 can still be built with min-ios-ver 6.0)
It also enforces minSDK of 8.0. Right now you can build apps with minSDK of 7.0
Major code changes include the following
As part of this we have also enabled most of the compiler flags suggested by XCODE
The following warnings are still generated
2a. Enable undeclared selector warning - We will probably not enable this flag anytime soon due to the amount of code refactor required
2b. Enable Unreachable Code warning - We will defer enabling this flag till we factor out the SCListener and MGSplitViewController libraries
2c. Enable Implicit conversion to 32 bit - This will generate warning in the a few third party library. We can choose to keep this disabled but should update titanium code to not generate this warning if enabled.
2d. Automatically select architectures - This will done as part of 64bit support
Regression path - KitchenSink