[TIMOB-18765] (4_0_X) ImageView cleanup #6834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already convert the image parameter to a URL through sanitizeURL. So loadURL does not need to pass the argument to TiUtils to convert it to a URL. Use the argument directly.
This was referenced May 11, 2015
pec1985
added a commit
that referenced
this pull request
May 11, 2015
[TIMOB-18765] (4_0_X) ImageView cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already convert the image parameter to a URL through sanitizeURL. So
loadURL does not need to pass the argument to TiUtils to convert it to
a URL. Use the argument directly.
Cherry Pick PR #6833 into 4_0_X
JIRA TICKETS:
TIMOB-18765
TIMOB-18889