[TIMOB-19694] Added support for launch screen storyboards for iOS 9 #7412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r. Fixed background rendering issue with iOS 8.
|
Fixed merge conflicts. |
| #else | ||
| chosenColor = [UIColor blackColor]; | ||
| #endif | ||
| } |
There was a problem hiding this comment.
If bgColor is not nil, it will not be assigned here. Is that intended?
There was a problem hiding this comment.
Not sure what you mean. chosenColor is either bgColor or black. If bgColor is nil, then chosenColor is nil. If chosenColor is nil, then we used to set it to black, but now we check if the colors are defined otherwise fallback to black. The code is good. Not sure what your concern is.
…generateXcodeUuid to member function so that plugins can use it.
… Changed the platform/iphone dest dir from the xcode app dir to the build dir to be in parity with Android and Windows. This will cause issues with existing apps and modules. However, added support for <project-dir>/hooks so people can add logic to copy files to the correct place.
…launch logos with a fallback to DefaultIcon.png. Added logic to remove certain app icons and launch images based on min iOS version and Xcode version. Removed --platform-dir from Android as it was an undocumented hack.
…nning is enabled.
…quire a sim restart. Sigh.
|
CR and FT passed! APPROVED! |
cheekiatng
added a commit
that referenced
this pull request
Dec 9, 2015
[TIMOB-19694] Added support for launch screen storyboards for iOS 9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-19694