Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-20595] Module Build: Update pre and post compile hooks event name 5_3_X #7868

Merged
merged 2 commits into from
Mar 19, 2016
Merged

[TIMOB-20595] Module Build: Update pre and post compile hooks event name 5_3_X #7868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e910ffa
[TIMOB-20595] Module Build: Update pre and post compile hooks event n…
feons Mar 18, 2016
192e6f6
add module token to pre.construct and finalize build events
feons Mar 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions android/cli/commands/_buildModule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,15 +178,15 @@ AndroidModuleBuilder.prototype.run = function run(logger, config, cli, finished)

appc.async.series(this, [
function (next) {
cli.emit('build.pre.construct', this, next);
cli.emit('build.module.pre.construct', this, next);
},

'doAnalytics',
'initialize',
'loginfo',

function (next) {
cli.emit('build.pre.compile', this, next);
cli.emit('build.module.pre.compile', this, next);
},

'compileAidlFiles',
Expand All @@ -204,10 +204,10 @@ AndroidModuleBuilder.prototype.run = function run(logger, config, cli, finished)
'runModule',

function (next) {
cli.emit('build.post.compile', this, next);
cli.emit('build.module.post.compile', this, next);
}
], function (err) {
cli.emit('build.finalize', this, function () {
cli.emit('build.module.finalize', this, function () {
finished(err);
});
});
Expand Down
15 changes: 12 additions & 3 deletions iphone/cli/commands/_buildModule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,22 +85,31 @@ iOSModuleBuilder.prototype.run = function run(logger, config, cli, finished) {

series(this, [
function (next) {
cli.emit('build.pre.construct', this, next);
cli.emit('build.module.pre.construct', this, next);
},

'doAnalytics',
'initialize',
'loginfo',

function (next) {
cli.emit('build.module.pre.compile', this, next);
},

'processLicense',
'processTiXcconfig',
'compileJS',
'buildModule',
'createUniBinary',
'verifyBuildArch',
'packageModule',
'runModule'
'runModule',

function (next) {
cli.emit('build.module.post.compile', this, next);
}
], function (err) {
cli.emit('build.finalize', this, function () {
cli.emit('build.module.finalize', this, function () {
finished(err);
});
});
Expand Down