[TIMOB-23529] Build: Replace scons and python with node scripts #8071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s ins erieis to avoid odd errors with unzip on build machine. Fix up package command to filter list of platforms against list for target OS
|
@cb1kenobi Hey Chris, looks like this PR is finally set to be reviewed. Thanks! |
| this.moduleApiVersion = moduleApiVersion; | ||
| this.gitHash = gitHash; | ||
| var date = new Date(); | ||
| this.timestamp = '' + (date.getMonth() + 1) + '/' + date.getDate() + '/' + (date.getYear()) + ' ' + date.getHours() + ':' + (date.getMinutes()); |
There was a problem hiding this comment.
Use date.getFullYear().
Also date.getMinutes() returns an unpadded number, so if the minutes is less than 10, it will not pad with a zero resulting in a time such as 17:2 instead of 17:02.
Perhaps it would be easiest to just do this:
this.timestamp = date.toLocaleDateString() + ' ' + date.toLocaleTimeString();
This will produce 6/23/2016 5:24:14 PM. If you want a 24 hour version, then you need to do:
this.timestamp = date.toLocaleDateString() + ' ' + date.toTimeString().replace(/^(\d+:\d+)(.*)$/, '$1');
There was a problem hiding this comment.
All right, just pushed that plus the left pad of hours and minutes with '0'.
…locally. Add section to README.md on building locally now that scons is gone
|
APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23529
I'd like to replace our build scripts in-place, so I'd prefer to get the build working on our PR build and then hopefully merging will just magically replace our build system.
To do so, I still need to take our existing build steps that run for titanium_mobile_master and migrate them into a bash script that lives in the repo itself - so that this PR can then overwrite part of that script to run our new node scripts instead of scons.
This PR does not yet replace the downloading of windows for builds, or uploading the built zips for all OSes up to S3. It also assumes you have Xcode/Android SDK/Android NDK, etc installed (i.e. I didn't write a script to fetch and set up pre-requisites yet).