iOS: Fix all memory leaks, Xcode-8 warnings & analyzer comments #8074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… FIX-MEMORY_LEAKS # Conflicts: # iphone/Classes/SCListener.m # iphone/Classes/TiMediaAudioSession.m # iphone/Classes/TiMediaSoundProxy.m
hansemannn
changed the title
… FIX-MEMORY_LEAKS # Conflicts: # iphone/Classes/MGSplitView/MGSplitViewController.m # iphone/iphone/Titanium.xcodeproj/project.pbxproj
| return; | ||
| } | ||
| if (![ourContactStore executeSaveRequest:saveRequest error:&error]) { | ||
| [self throwException:[NSString stringWithFormat:@"Unable to add member to group: %@",[TiUtils messageFromError:error]] | ||
| subreason:nil | ||
| location:CODELOCATION]; | ||
| }; | ||
| RELEASE_TO_NIL(saveRequest) |
There was a problem hiding this comment.
these changes to TiContactsGroup cannot be done. See
https://jira.appcelerator.org/browse/TIMOB-20010
It was done before and I had to revert it because this causes issues.
see this commit:
a0d4a50
|
If so, we would need to at least make a new PR for 92f08ca, maybe together with the updated default-entitlements that cause problems in Xcode 8. |
… FIX-MEMORY_LEAKS # Conflicts: # iphone/Classes/TiUITextField.m # iphone/Classes/TiUIiOSProxy.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23542