[TIMOB-24225] Fire close event on Ti.UI.Window close

[garymathews]

• close event is not fired when a Titanium.UI.Window is closed
• This should fix the failing close event is fired mocha test
• Add argument validation to BufferProxy.append()

TEST CASE

var b = Ti.UI.createWindow({backgroundColor: 'red'}),
    w = Ti.UI.createWindow({backgroundColor: 'yellow'});
 
w.addEventListener('close', function () {
    b.setBackgroundColor('green');
});
b.addEventListener('open', function () {
    w.addEventListener('open', function() {
        setTimeout(function () {
            w.close();
        }, 500);
    });
    w.open();
});
 
b.open();

• Window should be green

JIRA Ticket

[garymathews]

test this please

[garymathews]

test this please

[sgtcoolguy]

Just a note that the Jenkins build failed a handful of network related tests due to firewall issues on the internal build agent. I'm working on getting the sites used in our unit tests whitelisted.

[garymathews]

Ah okay, thanks!

[garymathews]

test this please

[garymathews]

All tests are passing, merging.

[frankieandone]

Didn't you basically undo the changes from PR for JIRA ticket?

[garymathews]

@fmerzadyan no, look at the changes.