Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24389] : iOS Appcelerator Titanium App Crashes after some usage time #8853

Merged
merged 5 commits into from
Mar 7, 2017
Merged

[TIMOB-24389] : iOS Appcelerator Titanium App Crashes after some usage time #8853

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
759a200
[TIMOB-24389] : iOS Appcelerator Titanium App Crashes after some usag…
vijaysingh-axway Mar 1, 2017
eacba8b
[TIMOB-24389]:iOS Appcelerator Titanium App Crashes after some usage …
vijaysingh-axway Mar 2, 2017
e4606e1
indentation fix
vijaysingh-axway Mar 2, 2017
9a9b73e
comment update
vijaysingh-axway Mar 2, 2017
1029316
[TIMOB-24389]: iOS Appcelerator Titanium App Crashes after some usage…
vijaysingh-axway Mar 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion iphone/Classes/MediaModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2095,8 +2095,14 @@ - (void)imagePickerController:(UIImagePickerController *)picker_ didFinishPickin
if (cropRect != nil) {
[dictionary setObject:cropRect forKey:@"cropRect"];
}
[self sendPickerSuccess:dictionary];

#ifndef TI_USE_KROLL_THREAD
//TIMOB-24389 : iOS: Appcelerator Titanium App Crashes after some usage time
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Describe the issue rather then paste the ticket title. That will help others to get the details more quickly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrote small note about problem. In ticket I think most of the things are explained.

KrollContext *krollContext = [self.pageContext krollContext];
[krollContext forceGarbageCollectNow];
#endif
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to dispatchCallback: instead, so it's ensured to be called for video capturing & editing as well? Or do you see down-sides there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No side effect. Moved to dispatchCallback.

}

- (void)imagePickerControllerDidCancel:(UIImagePickerController *)picker_
Expand Down