Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24438] Update Android Support Library to 23.4.0 #8858

Merged
merged 12 commits into from
May 6, 2017
Merged

[TIMOB-24438] Update Android Support Library to 23.4.0 #8858

merged 12 commits into from
May 6, 2017

Conversation

janvennemann
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-24438

Optional Description:
Updates the bundled Android Support Library to the latest version for API level 23, which is 23.4.0

@hansemannn
Copy link
Collaborator

Niceeeee!

@janvennemann janvennemann mentioned this pull request Mar 8, 2017
Merged
hansemannn and others added 5 commits April 18, 2017 20:00
@hansemannn
Merge branch 'master' into TIMOB-24438
5224fb7
@janvennemann
[TIMOB-24438] Remove old cardview library
f1600b0 
Replaced with cardview-v7-23.4.0.jar in b3c6427
@janvennemann
[TIMOB-24438] Update cardview resource to 23.4.0
75d28a5
@janvennemann
[TIMOB-24438] Update appcompat resources to 23.4.0
0e102ce
@janvennemann
[TIMOB-24438] Add internal spport v4 jar to dependency list
b483a2d 
The support-v4 .aar contains an additional .jar file in version 23.4.0. To properly include that library, it needs to be added to the appcompat dependency list.
@hansemannn
Copy link
Collaborator

@janvennemann Quick question: What prevents us from using 25.x again? Our build tools? Can't we update those as well to achieve latest support?

garymathews
garymathews approved these changes May 3, 2017
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@janvennemann
Copy link
Contributor Author

@hansemannn, i tried that but i think there were some issues, can't remember what exactly right now. @garymathews got the SDK to work with API 25 in the meantime so let me double check that again.

@garymathews
Copy link
Contributor

@janvennemann Want me to push a PR for that?

@janvennemann
Copy link
Contributor Author

@garymathews sure, if you have the time that could probably be interesting for 6.2.0. I'll leave the Support Libraries at 23.4.0 for know as this is intended for 6.1.0 and we most likely stay on API level 23 there.

@garymathews
Copy link
Contributor

@janvennemann Yes, I think this should go into 6.1.0, since it's only a minor bump.

@janvennemann janvennemann added this to the 6.1.0 milestone May 4, 2017
@janvennemann janvennemann mentioned this pull request May 4, 2017
Merged
@lokeshchdhry
Copy link
Contributor

FR Passed.
Followed steps in https://jira.appcelerator.org/browse/TIMOB-24438?focusedCommentId=419016&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-419016
Did not see any issues.

Studio Ver: 4.9.0.201704240654
SDK Ver: 6.2.0.v20170504083145
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.2
Appc NPM: 4.2.9
Appc CLI: 6.2.0
Ti CLI Ver: 5.0.12
Alloy Ver: 1.9.11
Node Ver: 6.10.1
Java Ver: 1.8.0_101
Devices: > google Nexus 6P --- Android 7.1.1
> google Nexus 6 --- Android 6.0.1

@lokeshchdhry lokeshchdhry merged commit 317979d into tidev:master May 6, 2017
@janvennemann janvennemann mentioned this pull request May 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees

@garymathews garymathews

Labels
android improvement
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@janvennemann @hansemannn @garymathews @lokeshchdhry