Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-16622] iOS:Replace UISearchDisplayController with UISearchController #9066

Merged
merged 23 commits into from
Aug 8, 2017
Merged

[TIMOB-16622] iOS:Replace UISearchDisplayController with UISearchController #9066

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
5d2ee66
[TIMOB-16622]: Replaced UISearchDisplayController with UISearchContro…
vijaysingh-axway May 17, 2017
65e8ec4
[TIMOB-16622]:Replace UISearchDisplayController with UISearchController
vijaysingh-axway May 17, 2017
8f0bda9
[TIMOB-16622]: check applied when search is active
vijaysingh-axway May 18, 2017
326854a
[TIMOB-16622]:default of dimsbackgroundcolor set
vijaysingh-axway May 18, 2017
cc5626d
Merge branch 'master' into TIMOB-16622
hansemannn May 18, 2017
92c5bd0
[TIMOB-16622]: In TiUITableView UISearchDisplayController replaced w…
vijaysingh-axway May 19, 2017
715fd6a
Merge branch 'TIMOB-16622' of https://github.com/vijaysingh-axway/tit…
vijaysingh-axway May 19, 2017
82777b6
code alignment
vijaysingh-axway May 19, 2017
da16438
[TIMOB-16622]:width of search bar fixed while rotation
vijaysingh-axway May 19, 2017
11151f1
Merge branch 'TIMOB-16622' of https://github.com/vijaysingh-axway/tit…
vijaysingh-axway May 19, 2017
9dcf45d
Merge branch 'master' into TIMOB-16622
hansemannn May 26, 2017
8276351
Merge branch 'master' into TIMOB-16622
hansemannn May 28, 2017
32ad6f8
[TIMOB-16622]:Doc updated
vijaysingh-axway May 29, 2017
7c492f6
[TIMOB-16622]:Doc updated with proper formatting
vijaysingh-axway May 29, 2017
0c21389
[TIMOB-16622]: UISearchController used in place of deprecated UISearc…
vijaysingh-axway Jun 19, 2017
019f1f5
[TIMOB-16622]:UISearhViewController used instead of UISearchDisplayCo…
vijaysingh-axway Jun 19, 2017
0870b11
[TIMOB-16622]: dimBackgroundForSearch property documented
vijaysingh-axway Jun 20, 2017
9089e31
Merge branch 'master' into TIMOB-16622
hansemannn Jul 4, 2017
7b84063
[TIMOB-16622] Fix minor outstanding review-issues
hansemannn Jul 4, 2017
ad81b10
[TIMOB-16622]: If search bar separately to listview
vijaysingh-axway Jul 19, 2017
333ac7d
Merge branch 'master' into TIMOB-16622
mukherjee2 Aug 2, 2017
d3eacd2
Merge branch 'master' into TIMOB-16622
ewieberappc Aug 8, 2017
4396c00
Merge branch 'master' into TIMOB-16622
ewieberappc Aug 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 17 additions & 1 deletion apidoc/Titanium/UI/ListView.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,6 +1069,10 @@ properties:
since: 6.1.0
platforms: [iphone, ipad]
availability: creation
removed:
since: "6.2.0"
notes: |
The background color of the search table-view is determined by it's table-view, so there is no additional property required.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the way the docs are written. Please check how other docs handle removal, also remember to break long lines into separate ones.

- name: resultsSeparatorColor
summary: |
Expand All @@ -1083,6 +1087,10 @@ properties:
since: 6.1.0
platforms: [iphone, ipad]
availability: creation
removed:
since: "6.2.0"
notes: |
The separator color of the search table-view is determined by it's table-view, so there is no additional property required.

- name: resultsSeparatorStyle
summary: The separator style of the search results (iOS-only).
Expand All @@ -1091,6 +1099,10 @@ properties:
since: 6.1.0
platforms: [iphone, ipad]
availability: creation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing them is not an option. Can't we just grab the values and style the search-tableview accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really necessary? Problem mentioned in ticket will not arise.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, but we need to state that, by using:

removed: 
    since: "6.2.0"
    notes: |
        The styling of the search table-view is determined by it's table-view, so there
        is no additional styling required.

removed:
since: "6.2.0"
notes: |
The styling of the search table-view is determined by it's table-view, so there is no additional styling required.

- name: resultsSeparatorInsets
summary: |
Expand All @@ -1104,7 +1116,11 @@ properties:
since: 6.1.0
platforms: [iphone, ipad]
availability: creation

removed:
since: "6.2.0"
notes: |
The separator insets of the search table-view is determined by it's table-view, so there is no additional property required.

methods:
- name: scrollToItem
summary: Scrolls to a specific item.
Expand Down
4 changes: 2 additions & 2 deletions iphone/Classes/TiUIListView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@

#if IS_XCODE_8
// Add support for iOS 10 table-view prefetching
@interface TiUIListView : TiUIView <UITableViewDelegate, UITableViewDataSource, UITableViewDataSourcePrefetching, UIScrollViewDelegate, UIGestureRecognizerDelegate, UISearchBarDelegate, UISearchDisplayDelegate, TiScrolling, TiProxyObserver, TiUIListViewDelegateView>
@interface TiUIListView : TiUIView <UITableViewDelegate, UITableViewDataSource, UITableViewDataSourcePrefetching, UIScrollViewDelegate, UIGestureRecognizerDelegate, UISearchBarDelegate,UISearchResultsUpdating, UISearchControllerDelegate, TiScrolling, TiProxyObserver, TiUIListViewDelegateView>
#else
@interface TiUIListView : TiUIView <UITableViewDelegate, UITableViewDataSource, UIScrollViewDelegate, UIGestureRecognizerDelegate, UISearchBarDelegate, UISearchDisplayDelegate, TiScrolling, TiProxyObserver, TiUIListViewDelegateView>
@interface TiUIListView : TiUIView <UITableViewDelegate, UITableViewDataSource, UIScrollViewDelegate, UIGestureRecognizerDelegate, UISearchBarDelegate, UISearchResultsUpdating, UISearchControllerDelegate, TiScrolling, TiProxyObserver, TiUIListViewDelegateView>
#endif

#pragma mark - Private APIs
Expand Down