-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-16622] iOS:Replace UISearchDisplayController with UISearchController #9066
Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
5d2ee66
[TIMOB-16622]: Replaced UISearchDisplayController with UISearchContro…
vijaysingh-axway 65e8ec4
[TIMOB-16622]:Replace UISearchDisplayController with UISearchController
vijaysingh-axway 8f0bda9
[TIMOB-16622]: check applied when search is active
vijaysingh-axway 326854a
[TIMOB-16622]:default of dimsbackgroundcolor set
vijaysingh-axway cc5626d
Merge branch 'master' into TIMOB-16622
hansemannn 92c5bd0
[TIMOB-16622]: In TiUITableView UISearchDisplayController replaced w…
vijaysingh-axway 715fd6a
Merge branch 'TIMOB-16622' of https://github.com/vijaysingh-axway/tit…
vijaysingh-axway 82777b6
code alignment
vijaysingh-axway da16438
[TIMOB-16622]:width of search bar fixed while rotation
vijaysingh-axway 11151f1
Merge branch 'TIMOB-16622' of https://github.com/vijaysingh-axway/tit…
vijaysingh-axway 9dcf45d
Merge branch 'master' into TIMOB-16622
hansemannn 8276351
Merge branch 'master' into TIMOB-16622
hansemannn 32ad6f8
[TIMOB-16622]:Doc updated
vijaysingh-axway 7c492f6
[TIMOB-16622]:Doc updated with proper formatting
vijaysingh-axway 0c21389
[TIMOB-16622]: UISearchController used in place of deprecated UISearc…
vijaysingh-axway 019f1f5
[TIMOB-16622]:UISearhViewController used instead of UISearchDisplayCo…
vijaysingh-axway 0870b11
[TIMOB-16622]: dimBackgroundForSearch property documented
vijaysingh-axway 9089e31
Merge branch 'master' into TIMOB-16622
hansemannn 7b84063
[TIMOB-16622] Fix minor outstanding review-issues
hansemannn ad81b10
[TIMOB-16622]: If search bar separately to listview
vijaysingh-axway 333ac7d
Merge branch 'master' into TIMOB-16622
mukherjee2 d3eacd2
Merge branch 'master' into TIMOB-16622
ewieberappc 4396c00
Merge branch 'master' into TIMOB-16622
ewieberappc File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -578,10 +578,10 @@ - (void)updateSearchResults:(id)unused | |
{ | ||
if (searchActive) { | ||
[self buildResultsForSearchText]; | ||
[resultViewController.tableView reloadData]; | ||
} | ||
else { | ||
[_tableView reloadData]; | ||
[_tableView reloadData]; | ||
if ([searchController isActive]) { | ||
[resultViewController.tableView reloadData]; | ||
} | ||
} | ||
|
||
|
@@ -898,7 +898,11 @@ -(void)setCaseInsensitiveSearch_:(id)args | |
caseInsensitiveSearch = [TiUtils boolValue:args def:YES]; | ||
if (searchActive) { | ||
[self buildResultsForSearchText]; | ||
[_tableView reloadData]; | ||
if ([searchController isActive]) { | ||
[[resultViewController tableView] reloadData]; | ||
} else { | ||
[_tableView reloadData]; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question as above. |
||
} | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation. Also, when would
searchActive
beNO
but[searchController isActive]
beYES
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are 2 ways we can use search in list view -
In second way, when we click on searchbar [searchController isActive] will be yes.
But for searchActive being to Yes, there should be atleast one character in search bar.
So when second way of search used, user clicked on search bar and not typed any character, [searchController isActive] will be YES and searchActive will be NO.
If you see the old implementation, it is in same way.
Are you sure there is problem in indentation, I don't think so.