Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24898] Allow background transparency when borderRadius is set #9179

Merged
merged 2 commits into from
Jul 6, 2017
Merged

[TIMOB-24898] Allow background transparency when borderRadius is set #9179

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bbf07e
[TIMOB-24898] Allow background transparency when borderRadius is set
Jun 29, 2017
b664a3d
Merge branch 'master' into TIMOB-24898
Jul 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions android/titanium/src/java/org/appcelerator/titanium/view/TiUIView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,6 +873,12 @@ public void propertyChanged(String key, Object oldValue, Object newValue, KrollP
} else if (key.startsWith(TiC.PROPERTY_BORDER_PREFIX)) {
handleBorderProperty(key, newValue);
}

// TIMOB-24898: disable HW acceleration to allow transparency
// when the backgroundColor alpha channel has been set
if ((byte)(bgColor >> 24) < 0xFF) {
disableHWAcceleration();
}
}

applyCustomBackground();
Expand Down Expand Up @@ -1422,6 +1428,12 @@ private void initializeBorder(KrollDict d, Integer bgColor)
}
}
}

// TIMOB-24898: disable HW acceleration to allow transparency
// when the backgroundColor alpha channel has been set
if ((byte)(bgColor >> 24) < 0xFF) {
disableHWAcceleration();
}
}
}

Expand Down