-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-24982] Android/iOS: Add WebView zoomLevel #9226
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
9c15b71
add zoomBy
m1ga c2b5910
Merge branch 'master' into zoomBy
m1ga 5f3b916
Merge branch 'master' into zoomBy
m1ga ec3faf9
Merge branch 'zoomBy' of https://github.com/m1ga/titanium_mobile into…
m1ga 5fbb647
[TIMOB-24982] Expose "zoomLevel", add docs
hansemannn 4c75fd3
Merge pull request #3 from hansemannn/TIMOB-24982
m1ga 1b17f3f
zoomBy -> zoomLevel
m1ga 26b6280
Merge branch 'zoomBy' of https://github.com/m1ga/titanium_mobile into…
m1ga adba36a
Merge branch 'master' into zoomBy
m1ga 85696af
Update WebView.yml
hansemannn 7a43e59
Update WebView.yml
hansemannn 64d9ac1
Update WebViewProxy.java
m1ga 884ebb3
Merge branch 'master' into zoomBy
m1ga bff8cd2
Merge branch 'master' into zoomBy
m1ga 582dc39
Update TiUIWebViewProxy.m
hansemannn 30af365
Update default value, check api level, change since version
m1ga 2145a8b
update scale
m1ga c1a4ff8
merge master
m1ga 0fd721e
removed log
m1ga 1cb5ce3
move version check into zoomBy function
m1ga 809281f
Merge branch 'master' into zoomBy
m1ga bba3c90
Merge branch 'master' into zoomBy
m1ga 26674c7
Update WebView.yml
hansemannn 9ca3005
Update TiUIWebView.m
hansemannn acd0d8f
Update TiUIWebViewProxy.m
hansemannn 18b2d7d
Merge branch 'master' into zoomBy
hansemannn f9a5ae1
clang-format
m1ga fff87a6
Merge branch 'master' into zoomBy
m1ga 1d1f4b5
clang off/on
m1ga 619bdf7
Merge branch 'master' into zoomBy
m1ga 7f84e75
Update WebView.yml
hansemannn 7fba15b
Merge branch 'master' into zoomBy
hansemannn e2ec1bd
Merge branch 'master' into zoomBy
hansemannn a9f7aff
Attempt to fix merge conflict
hansemannn e892eb6
Merge branch 'master' into zoomBy
lokeshchdhry 1158f03
return correct values
m1ga 9a356ed
Merge branch 'master' into zoomBy
m1ga 25cf084
Merge branch 'master' into zoomBy
hansemannn File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This public zoomBy() method is missing an API Level 21 check like how we handle the zoom level property. Either add the API Level check here too or move all the API Level checks to the private zoomBy() method.