-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-24988] Android: Add Ti.Network.Cookie isValid() #9230
Conversation
@Kroll.method | ||
public boolean isValid() | ||
{ | ||
String name = TiConvert.toString(getProperty(TiC.PROPERTY_NAME), ""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to set a default value in this case, saves creating empty String objects:
String name = TiConvert.toString(getProperty(TiC.PROPERTY_NAME));
String value = TiConvert.toString(getProperty(TiC.PROPERTY_VALUE));
String path = TiConvert.toString(getProperty(TiC.PROPERTY_PATH));
String domain = TiConvert.toString(getProperty(TiC.PROPERTY_DOMAIN));
return (name != null && value != null && path != null && domain != null);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
@m1ga Can you provide a 6_2_X PR as well? Currently this would only go into 7.0.0 |
FR Passed.
Studio Ver: 4.9.1.201707200100 |
JIRA: https://jira.appcelerator.org/browse/TIMOB-24988
Parity with iOS
Test code