Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26068] Android: Improve Ti.UI.Toolbar default behavior #9367

Merged
merged 16 commits into from
May 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ private TiToolbar getTiToolbarView()
@Override
public TiUIView createView(Activity activity)
{
//fill the container width by default
if (!hasProperty(TiC.PROPERTY_WIDTH)) {
setProperty(TiC.PROPERTY_WIDTH, UIModule.FILL);
}
return new TiToolbar(this);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import android.support.v7.widget.Toolbar;
import android.view.View;
import android.view.Window;

import org.appcelerator.kroll.KrollDict;
import org.appcelerator.kroll.KrollProxy;
import org.appcelerator.kroll.common.AsyncResult;
Expand Down
2 changes: 1 addition & 1 deletion apidoc/Titanium/UI/Toolbar.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ description: |
* [Toolbar in the iOS Human Interface Guidelines.](https://developer.apple.com/ios/human-interface-guidelines/bars/toolbars/)

extends: Titanium.UI.View
excludes: { properties: [ backgroundColor, backgroundDisabledColor, backgroundDisabledImage,
excludes: { properties: [ backgroundColor, backgroundDisabledColor, backgroundDisabledImage,
backgroundFocusedColor, backgroundFocusedImage,
backgroundLeftCap, backgroundTopCap, backgroundRepeat,
backgroundSelectedColor, backgroundSelectedImage, layout,
Expand Down