-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-17821] Android: Add Support for Custom View to ActionBar #9425
Merged
Merged
Changes from 14 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
06e77ee
Expose setCustomView method.
ypbnv 7ff934a
Add docs.
ypbnv e4310e6
Merge branch 'master' into TIMOB-17821
ypbnv b13cfda
Merge branch 'master' into TIMOB-17821
ypbnv 037cdea
Merge branch 'master' into TIMOB-17821
ypbnv 0b0f84d
Fix formatting.
ypbnv 4ad3cdd
Merge branch 'master' into TIMOB-17821
ypbnv c3390fa
Merge branch 'master' into TIMOB-17821
ypbnv 324e29d
Merge branch 'master' into TIMOB-17821
ypbnv 25d3d8a
Merge branch 'master' into TIMOB-17821
ypbnv c086bc2
Merge branch 'master' into TIMOB-17821
ypbnv b0bbdc1
Merge branch 'master' into TIMOB-17821
ypbnv 6df0182
Extract customView as a field. Add null as a valid value.
ypbnv 488883a
Merge branch 'master' into TIMOB-17821
ypbnv 60fdfab
Merge branch 'master' into TIMOB-17821
ypbnv 602568e
Merge branch 'master' into TIMOB-17821
ypbnv 4cc3647
Merge branch 'master' into TIMOB-17821
ypbnv 0a6bf11
Merge branch 'master' into TIMOB-17821
ypbnv 11e988f
Merge branch 'master' into TIMOB-17821
ypbnv fa2e643
Merge branch 'master' into TIMOB-17821
2b5b39d
Merge branch 'master' into TIMOB-17821
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of setters without getters. Ideally, this should be a
customView
property which we should then callhandleSetCustomView()
when the property changes.