[TIMOB-25319] Fixed export options when packaging app that uses Cloud Kit. #9446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
requested changes
Sep 19, 2017
iphone/cli/hooks/package.js
Outdated
| const entitlementsFile = path.join(builder.buildDir, builder.tiapp.name + '.entitlements'); | ||
| if (fs.existsSync(entitlementsFile)) { | ||
| const plist = new appc.plist(entitlementsFile); | ||
| if (Object.keys(plist).some(function (key) { return key === 'com.apple.developer.icloud-container-identifiers'; })) { |
There was a problem hiding this comment.
Linting error in Jenkins:
iphone/cli/hooks/package.js
-> 231:49 error This line has 2 statements. Maximum allowed is 1 max-statements-per-line
This will be so awesome once we integrate Danger.js 🚀
hansemannn
approved these changes
Sep 19, 2017
|
FR Passed. Able to package projects using CloudKit for adhoc and app store without issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25319