Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25318] Fixed bug where sim builds were blowing up when incorre… #9474

Merged
merged 1 commit into from
Sep 23, 2017
Merged

[TIMOB-25318] Fixed bug where sim builds were blowing up when incorre… #9474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion iphone/cli/commands/_build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1999,7 +1999,7 @@ iOSBuilder.prototype.validate = function validate(logger, config, cli) {

function validateTeamId() {
this.teamId = this.tiapp.ios['team-id'];
if (!this.teamId) {
if (!this.teamId && this.provisioningProfile) {
if (this.provisioningProfile.team.length === 1) {
// only one team, so choose this over the appPrefix
this.teamId = this.provisioningProfile.team[0];
Expand Down
2 changes: 1 addition & 1 deletion iphone/cli/hooks/package.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ exports.init = function (logger, config, cli) {
exportsOptions.method = 'enterprise';
}

if (builder.teamId || pp.team || pp.appPrefix) {
if (builder.teamId || (pp && (pp.team || pp.appPrefix))) {
// NOTE: if there isn't an explicit <team-id> in the tiapp.xml and there is no
// teams or more than 1 team in the provisioning profile, then we use the appPrefix
// which should be the team id, but can differ and since we don't check it, this
Expand Down